Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a single test location #66

Closed
amtoine opened this issue Nov 5, 2023 · 0 comments · Fixed by #103
Closed

use a single test location #66

amtoine opened this issue Nov 5, 2023 · 0 comments · Fixed by #103
Assignees
@amtoine
Labels
core Related to the main `nu-git-manager` module refactor Changes that just moves code around without altering features tests Something related to the tests of the library

Comments

@amtoine
Copy link
Owner

amtoine commented Nov 5, 2023

as per title, i would like to refactor the base directories of all the tests to be the same, to avoid messing around too much with the filesystem.
@amtoine amtoine added tests Something related to the tests of the library refactor Changes that just moves code around without altering features core Related to the main `nu-git-manager` module labels Nov 5, 2023
@amtoine amtoine self-assigned this Nov 19, 2023
@amtoine amtoine mentioned this issue Nov 19, 2023
Merged
amtoine added a commit that referenced this issue Nov 21, 2023
@amtoine
refactor the test dir setup in tests/common/setup.nu (#103)
25b7c03 
- should close #66 

## description
this PR simply makes sure all the tests use the same base location to
dump all their files.

this is computed as a random directory in the new `get-random-test-dir`
command.

> **Note**
> i had to add a `--no-sanitize` switch to `get-random-test-dir` to
disable the sanitization for the `tests detect-grafting` and `tests
store-cleaning` tests, otherwise the tests did not pass on Windows...
:shrug: :laughing:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amtoine amtoine

Labels
core Related to the main `nu-git-manager` module refactor Changes that just moves code around without altering features tests Something related to the tests of the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor the test dir setup in tests/common/setup.nu amtoine/nu-git-manager
1 participant
@amtoine