Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a CI #27

Merged
merged 4 commits into from
Oct 19, 2023
Merged

add a CI #27

merged 4 commits into from
Oct 19, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Oct 12, 2023

related to

wait for these to land

description

this PR

@amtoine amtoine added the ci Something related to the Continuous Integration label Oct 12, 2023
@amtoine amtoine mentioned this pull request May 8, 2023
4 tasks
@amtoine
Copy link
Owner Author

amtoine commented Oct 12, 2023

as you can see in the failing CI, this PR requires nushell/nupm@177357c from nushell/nupm#30, let's wait for nushell/nupm#30 to try this PR again 😌

@amtoine
Copy link
Owner Author

amtoine commented Oct 16, 2023

nushell/nupm#30 has landed, let's give this another shot 😏

@amtoine amtoine marked this pull request as ready for review October 16, 2023 16:30
@amtoine amtoine requested a review from melMass October 16, 2023 16:30
@amtoine
Copy link
Owner Author

amtoine commented Oct 16, 2023

@melMass
quite happy to announce that this is finally ready for review 😌

Copy link
Collaborator

@melMass melMass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@melMass melMass merged commit 4147388 into main Oct 19, 2023
3 checks passed
@melMass melMass deleted the add-a-ci branch October 19, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Something related to the Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants