Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preloader added #423

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Shreyans2004
Copy link

Description

I have added the preloader.Can it be merged now?
Please provide a brief description of the changes introduced in this pull request. Explain the problem you are solving or the feature you are adding.

Pull Request Checklist

Please make sure that your PR meets the following requirements:

  • The app is working correctly after applying the changes.
  • [] The app is responsive and displays properly on different screen sizes and devices.
  • The changes are thoroughly documented in the appropriate files or documentation sections.
  • The coding conventions and style guidelines are followed consistently.

Checklist

Please check all applicable boxes and provide any additional information if needed.

  • I have tested the changes locally and ensured that the app is functioning as expected.
  • I have verified that the app is responsive and looks good on various screen sizes and devices.
  • I have reviewed the documentation and ensured that it accurately reflects the changes made.
  • I have followed the coding conventions and style guidelines defined in the project.
  • I have run the automated tests and all of them pass.
  • I have considered the performance implications of the changes made.
  • I have considered the security implications of the changes made.
  • I have checked for any potential regressions or side effects caused by the changes.
  • I have performed a self-review of my code.
  • Starred the repository.
  • Added My Name to the Contributor's List.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)

Additional Notes(Optional)

Please provide any additional information or context that may be helpful for reviewing the pull request.

Related Issues

Please list any related issues or pull requests that are associated with this pull request.

Reviewers

Please tag the relevant team members or reviewers who should review this pull request.

@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 11:47am

@github-actions
Copy link

Thank you, @Shreyans2004, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇
Please make sure you have marked all the completed tasks as done. ✅
We appreciate your patience and contribution! 😀

@github-actions github-actions bot added the gssoc23 This is label for GirlScript Summer of Code label Jun 16, 2023
@anmode
Copy link
Member

anmode commented Jun 17, 2023

Screen.Recording.2023-06-17.at.3.03.35.PM.mov

It is not optimized!! Please look at....

Copy link
Contributor

@tusharbansal22 tusharbansal22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preloader should not sit on top of the page, but should be the page while the website is loading..

@Shreyans2004
Copy link
Author

Ya, I'll look at it

@Shreyans2004
Copy link
Author

I have done some change.Can it be merged now?

@Harshil-Jani
Copy link
Collaborator

I have done some change.Can it be merged now?

@Shreyans2004 I see the site page being rendered twice. In simple terms, After footer I can see navbar and whole thing repeating. Please take a look in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This is label for GirlScript Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants