-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preloader added #423
base: master
Are you sure you want to change the base?
Preloader added #423
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you, @Shreyans2004, for creating this pull request and contributing to GitHub-ReadMe! 💗 Our review team will thoroughly review the pull request and will reach out to you soon! 😇 |
Screen.Recording.2023-06-17.at.3.03.35.PM.movIt is not optimized!! Please look at.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preloader should not sit on top of the page, but should be the page while the website is loading..
Ya, I'll look at it |
I have done some change.Can it be merged now? |
@Shreyans2004 I see the site page being rendered twice. In simple terms, After footer I can see navbar and whole thing repeating. Please take a look in this. |
Description
I have added the preloader.Can it be merged now?
Please provide a brief description of the changes introduced in this pull request. Explain the problem you are solving or the feature you are adding.
Pull Request Checklist
Please make sure that your PR meets the following requirements:
Checklist
Please check all applicable boxes and provide any additional information if needed.
Screenshots - If Any (Optional)
Additional Notes(Optional)
Please provide any additional information or context that may be helpful for reviewing the pull request.
Related Issues
Please list any related issues or pull requests that are associated with this pull request.
Reviewers
Please tag the relevant team members or reviewers who should review this pull request.