-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init creates a new package.json with an older version #424
Comments
This is definitely a bug. Looks like a botched release on my part, the package.json in the complete example did not get updated in the last release: https://github.com/amzn/style-dictionary/blob/master/examples/complete/package.json#L14 |
@dbanksdesign this is still in the codebase, lol... Can we just set to '*'? |
We could.... I don't know if that is a bad practice or not, I haven't seen '*' in very many package.json files. Let's take a look at how some other frameworks handle this. |
I mean, we could add it to the process for creating a tagged release... but it would be better if that was automated |
We have a pre-version script that should bump up all the version numbers of the examples, but it might be broken... If we moved the repository to a monorepo with each example as its own package then I think this could be handled nicer without a custom script... Maybe something to look in to. |
Fixed this in #755 |
Hello!
I was trying this out today, and found this behavior confusing:
yarn add --dev style-dictionary
- get latest version 2.10.0yarn run style-dictionary init complete
- the package.json gets templated value:I would expect that the generated template match the version installed - unless this is some other behavior?
The text was updated successfully, but these errors were encountered: