-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to upstream ruamel.yaml package #399
base: master
Are you sure you want to change the base?
Conversation
Avoid usage of deprecated top-level ruamel.yaml load/dump functions. Those have been removed in ruamel.yaml>=0.18 . Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
ref: conda-incubator/setup-miniconda#261 Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
.github/workflows/main.yml
Outdated
- uses: conda-incubator/setup-miniconda@v2.1.1 | ||
with: | ||
auto-update-conda: false | ||
miniconda-version: py37_4.10.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup-miniconda>=2.2
does not handle the py37_
prefix, see conda-incubator/setup-miniconda#261 .
(Over all, it would make sense to update versions to test against. That would need knowledge of what versions of conda
Anaconda intends to officially/unofficially support; i.e., not something I know and something better done in a separate PR.)
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
48cb88d
to
e733120
Compare
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@AlbertDeFusco , the CI was probably affected by https://www.githubstatus.com/incidents/x39xrr5m11b3 . |
I've started the tests and I'll take a look |
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
I took another look at the CI log and it seems the path to the Conda installation simply changed from |
CI failures are unrelated to the changes here (mostly probably just test code needing adjustments to changes in |
Closes gh-364.
Supersedes gh-365.
Switch to upstream ruamel.yaml package.
Avoid usage of deprecated top-level ruamel.yaml load/dump functions. Those have been removed in ruamel.yaml>=0.18 .
The dependency change was similarly done for
conda>=22.11
inruamel.yaml
conda/conda#11868with the
ruamel_yaml
fallback finally removed recently (forconda>23.10
) in