fix: can not download invalid utf8 named torrent #915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running on macOS sonoma 14.4 with M2 pro
I found some magnet with invalid utf8 name fail to download with this library. but meanwhile qbitorrent handle it well.
Maybe we should use
BestName
function in metainfo.Info andBestPath
function in metainfo.FileInfo which may returnhuman readable name in utf8 to successfully download this kind torrent.
before this patch invalid torrent will produce error message like this.
after this patch this torrent is successfully downloaded as 仙剑奇侠传三1080P