Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions descrepency #8

Closed
riggs opened this issue Jul 10, 2020 · 2 comments
Closed

Permissions descrepency #8

riggs opened this issue Jul 10, 2020 · 2 comments

Comments

@riggs
Copy link
Contributor

riggs commented Jul 10, 2020

https://github.com/trinamic/TMC-API/blob/077adb2820f6f907878ef65ccd4ba6ca35489dd2/tmc/ic/TMC5160/TMC5160.h#L75 shows 0x3D as reserved, but that's actually write-only ENC_DEVIATION. I'm guessing this is an error.

@riggs
Copy link
Contributor Author

riggs commented Jul 10, 2020

I'm also noticing that a number of buffers (GSTAT, RAMPSTAT, & ENC_STAT) are marked with 0x21: read, flag register (read to clear), when they're in fact write to clear flags. I would think these should be 0x23, possibly even with the clear bits set in the tmc5160_defaultRegisterResetState so the flags are cleared on reset.

@trinamic-LH
Copy link
Contributor

The register permissions are fixed in 3f5aa4c

As for clearing bits on reset - we don't do that on purpose. We want the API to have as few side effects as possible, including not clearing flags automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants