Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add perf changes from esbuild browser plugin #14

Closed
brandonroberts opened this issue Aug 5, 2022 · 3 comments
Closed

chore: add perf changes from esbuild browser plugin #14

brandonroberts opened this issue Aug 5, 2022 · 3 comments
Assignees

Comments

@brandonroberts
Copy link
Member

Adds checks to see if babel transform is needed

angular/angular-cli#23682

@pjlamb12
Copy link
Contributor

I'm unsure where the change that starts on line 371 of that PR should be added in Analog. My guess is in the object whose name is name: '@analogjs/vite-plugin-angular-optimizer' in the angular-vite-plugin.ts file, inside the transform method?

@pjlamb12
Copy link
Contributor

These are the changes I've begun making. I haven't worked with esbuild (or anything similar) before so I know this may need to change.

@brandonroberts
Copy link
Member Author

@pjlamb12 Thanks! Looking on track so far. You don't need to add the advancedOptimizations flag. Just use the isProd boolean that already exists inside the plugin. These changes would be added to both the @analogjs/vite-plugin-angular-optimizer and @analogjs/vite-plugin-angular transform functions.

Would be cleaner to separate the plugins into different files, but that can come as a separate effort.

pjlamb12 added a commit to pjlamb12/analog that referenced this issue Aug 24, 2022
adding more to the transform methods for the two plugins

relates to analogjs#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants