fix(nx-plugin): make nx plugin use 16.1 #467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
goetzrobin
force-pushed
the
fix-nx-plugin-16-point-1-incompatibility
branch
2 times, most recently
from
c82a28d
to
15efeab
Compare
currently the nx plugin let the nx angular init generator pick the version of angular to be installed. this meant that when the nx angular init generator picks 16.0.0, due to ~16.0.0 version in the nx repository, our created analog application did not work anymore. this fix makes sure the correct version ^16.1.0 is picked by nx tooling. unfortunately, semver does not like ^ in its versions so we have to remove it before finding the major version or ensuring compatibility.
goetzrobin
force-pushed
the
fix-nx-plugin-16-point-1-incompatibility
branch
from
15efeab
to
94e756d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the nx plugin let the nx angular init generator pick the version of angular to be installed. this meant that when the nx angular init generator picks 16.0.0, due to ~16.0.0 version in the nx repository, our created analog application did not work anymore. this fix makes sure the correct version ^16.1.0 is picked by nx tooling. unfortunately, semver does not like ^ in its versions so we have to remove it before finding the major version or ensuring compatibility.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
After upgrading to 0.2.0-beta.17 the Nx plugin breaks, due import paths that changed in Angular 16.1.
The Nx init generator we use to set up an Angular workspace under the hood currently uses ~16.0.0 as its
default version. This change ensures that ^16.1.0 is used for our Angular installation.
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Also including some minor clean ups and additional "safe guards" that should make dependency
management easier.
[optional] What gif best describes this PR or how it makes you feel?