Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): remove Pipe support and add exposes #826

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

nartc
Copy link
Member

@nartc nartc commented Jan 2, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

  • We're currently supporting authoring Pipe with .ng file
  • We're currently NOT supporting exposing global symbols like Math or from import statement like an Enum to the template.

Closes #

What is the new behavior?

  • Pipe is no longer supported with .ng file format. The users are recommended to use computed
  • Global symbols like Math can be exposed, if used on the template, with
<script lang="ts">
defineMetadata({
  exposes: [Math]
})
</script>

<template>
  <p>Random: {{ Math.random() }}</p>
</template>
  • Support onDestroy

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit fb18434
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65946dcb03f1c40008af1db5
😎 Deploy Preview https://deploy-preview-826--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit fb18434
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65946dcba9f8c8000835c9a3
😎 Deploy Preview https://deploy-preview-826--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit fb18434
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65946dcb176c7a000809d573
😎 Deploy Preview https://deploy-preview-826--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nartc nartc force-pushed the fix/ng-component branch 2 times, most recently from 12fb1b5 to e020fe8 Compare January 2, 2024 17:45
@brandonroberts brandonroberts merged commit c750116 into analogjs:main Jan 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants