Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite-plugin-angular): support inputs and outputs for .ng format #848

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

nartc
Copy link
Member

@nartc nartc commented Jan 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

No inputs/outputs support

What is the new behavior?

Input support via Signal Input (17.1 required)
Output support via new EventEmitter()

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 960bae6
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/659fff4c996f0c0008487f53
😎 Deploy Preview https://deploy-preview-848--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 960bae6
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/659fff4c05eefc000a0d83a2
😎 Deploy Preview https://deploy-preview-848--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 960bae6
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/659fff4c109bcd000898f759
😎 Deploy Preview https://deploy-preview-848--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nartc nartc self-assigned this Jan 11, 2024
@nartc nartc added the enhancement New feature or request label Jan 11, 2024
Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 960bae6
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/659fff4cc47f3700086eab3d
😎 Deploy Preview https://deploy-preview-848--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts
Copy link
Member

Changes LGTM. Will fix unit test failure for snapshots in a follow-up

@brandonroberts brandonroberts merged commit a6468db into analogjs:main Jan 12, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants