Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/carter qol -- finetuning cancelation support and retry logic #23

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

cartazio
Copy link
Contributor

No description provided.

@cartazio
Copy link
Contributor Author

retry logic for data synthesis (sometimes the models dont emit valid json), and adding a signal handler to cancel finetuning when you exit the program

@cartazio cartazio mentioned this pull request Jun 29, 2023
22 tasks
@abhigya-sodani
Copy link
Collaborator

Right now even if one datapoint has an issue (leads to unparseable JSON), the whole process in restarted. I think this is fine for now, but maybe in the future we want to have all the other datapoints that are still formatted correctly to still be used and just the bad datapoints ignored.

@abhigya-sodani
Copy link
Collaborator

while testing, I have been stuck doing generation for last 10 minutes because one datapoint has a parsing issue

@cartazio
Copy link
Contributor Author

@abhigya-sodani, thats some terrible luck! its set to fail after two tries by default, did you hit that limit or ?

@cartazio
Copy link
Contributor Author

I’m happy to add some more robust formatting tricks to this pr. Or are you comfortable with this being merged in as is ?

@abhigya-sodani
Copy link
Collaborator

Cntrl+c quitting was not working for me

@cartazio
Copy link
Contributor Author

Ok that’s weird. What os, terminal, and shell are you using?

@abhigya-sodani
Copy link
Collaborator

Anaconda Prompt, windows 10

@cartazio
Copy link
Contributor Author

Ok I think interrupts/signals aren’t supported on windows. I’ll check out if there’s a simple equivalent. If it’s easy for you to whip up a handler for native windows , I’ll stack that on

@cartazio cartazio merged commit 33b54f4 into main Jun 29, 2023
@cartazio cartazio deleted the feature/carter_qol branch June 29, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants