Add position option for Toast

[zhirzh]

fixes #218

[ritz078]

Repeating these will increase file size. Since these are strings, the change won't be negligible. We can't compromise on size for readability. So, extract these into separate objects and use them here.

[zhirzh]

replacing repeating code with a dynamic function gives slightly longer code (see here)

[ritz078]

That link is giving 404

[ritz078]

What I asked was different.

const centerTransfrom = {
  from: { transform: "translateX(-50%) translateY(-10px)" },
      enter: { transform: "translateX(-50%) translateY(0)" },
      leave: { transform: "translateX(-50%) translateY(-10px)" }
}

const customStyles = {
  [ToastPosition.TOP]: {
    style: {
      top: 20,
      left: "50%"
    },
  transitions: centerTransform
}}

now you can use centerTransform at two places.

[zhirzh]

the centerTransform object won't be usable by ToastPosition.BOTTOM because the translateY() is negative but needs to be positive

[ritz078]

also the tests are failing.

[zhirzh]

fixed tests

[ritz078]

change this to position

[zhirzh]

fixed in 5c997ea

[ritz078]

Also, It's crashing for TOP position in storybook

[azizhk]

Run yarn build and then yarn test to see these tests fail on your local machine.

[azizhk]

I guess tests are failing because the code generated by Typescript is not fully tree-shakeable.
microsoft/TypeScript#27604

[zhirzh]

exporting ToastPosition enum is the cause

var ToastPosition;
(function (ToastPosition) {
  ToastPosition[ToastPosition["BOTTOM"] = 0] = "BOTTOM";
  ToastPosition[ToastPosition["BOTTOM_LEFT"] = 1] = "BOTTOM_LEFT";
  ToastPosition[ToastPosition["BOTTOM_RIGHT"] = 2] = "BOTTOM_RIGHT";
  ToastPosition[ToastPosition["TOP"] = 3] = "TOP";
  ToastPosition[ToastPosition["TOP_LEFT"] = 4] = "TOP_LEFT";
  ToastPosition[ToastPosition["TOP_RIGHT"] = 5] = "TOP_RIGHT";
})(ToastPosition || (ToastPosition = {}));