Dropdown position bug fix #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritz078
reviewed
Apr 16, 2019
| @@ -75,13 +75,13 @@ class DropDown extends React.PureComponent<DropdownProps, DropdownState> { | |||
| )} | |||
| </Reference> | |||
|
|
|||
| <MountTransition visible={isOpen} native> | |||
| <MountTransition visible={isOpen}> | |||
There was a problem hiding this comment.
How does this make a difference ?
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 82.22% 82.25% +0.03%
==========================================
Files 75 75
Lines 1108 1110 +2
Branches 207 207
==========================================
+ Hits 911 913 +2
Misses 175 175
Partials 22 22
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 82.22% 82.25% +0.03%
==========================================
Files 75 75
Lines 1108 1110 +2
Branches 207 207
==========================================
+ Hits 911 913 +2
Misses 175 175
Partials 22 22
Continue to review full report at Codecov.
|
ritz078
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.