Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Create command reference topics for AMC #319

Merged
merged 23 commits into from
Dec 4, 2023

Conversation

keirthana
Copy link
Contributor

This is just a stop-gap until we have the auto generated docs in place. This PR does not require a lot of review as it is mostly from the CLI, just a quick one to see if there are any outdated commands listed.

Copy link
Contributor

@jat-canonical jat-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the docs auto generated or could we do something about the solo options for a few flags.


amc addon add <addon_name> (<directory> | <tarball> | <zip archive>) --timeout=3m

where `-t` or --`timeout` is a string value to denote the maximum wait time for the operation to complete. The default is `5m`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep this consistent like the table created below for delete ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just didn't want to add a table for just one flag and maybe -h. But if you feel it reads better that way, I can change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong perference. But for me personally, I like consistency so if some are in a table, I feel it might read better if all of them are. But if it is too much work to identify each one and you have to create it manually, then it is fine as is too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will push this as is for now, since there is a good chance of these getting overwritten when we automate the command docs.


amc addon list --format=(table | json |csv)

where `--format` option controls the output format which can be in the form of a table, JSON or CSV. The default value is `table`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above and for others with a single option ?

@keirthana
Copy link
Contributor Author

Are the docs auto generated or could we do something about the solo options for a few flags.

It's not fully automatic. I used some automation to pull content out and transform it into markdown format but either way, we can make changes.

Copy link
Contributor

@jat-canonical jat-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keirthana keirthana merged commit 9c0ff50 into anbox-cloud:main Dec 4, 2023
3 checks passed
@keirthana keirthana deleted the create-amc-cmd-ref branch December 12, 2023 06:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants