Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress invalid CVE-2016-1000027 #773

Closed
ThomasVitale opened this issue Jun 5, 2022 · 7 comments
Closed

Suppress invalid CVE-2016-1000027 #773

ThomasVitale opened this issue Jun 5, 2022 · 7 comments
Labels
bug Something isn't working false-positive

Comments

@ThomasVitale
Copy link

What happened:

The CVE-2016-1000027 is flagged as critical for applications using any 5.x version of the Spring Framework.

What you expected to happen:
The Spring team has explained that the CVE is invalid (spring-projects/spring-framework#24434 and details spring-projects/spring-framework#24434 (comment)), so I would expect grype not to flag it. An open issue also exists to reject this CVE: CVEProject/cvelist#5949.

How to reproduce it (as minimally and precisely as possible):

Scan with grype any application using any 5.x version of the Spring Framework.

@ThomasVitale ThomasVitale added the bug Something isn't working label Jun 5, 2022
@spiffcs spiffcs added this to OSS Jun 6, 2022
@Turbots
Copy link

Turbots commented Jul 12, 2022

+1 Please suppress this invalid CVE, as it is stopping a lot of people using Grype to continue with a certain application deployment... The security scanning step is stopping the CI/CD pipelines and preventing customers to go to production with new releases.

@spiffcs
Copy link
Contributor

spiffcs commented Jul 12, 2022

Thanks for the bump on this issue @Turbots and thank you @ThomasVitale for filing the issue. I'm working on closing a PR for grype at the moment and then will pick this up and resolve the FP based on the evidence provided and related support that's been listed.

@spiffcs spiffcs moved this to In Progress (Actively Resolving) in OSS Jul 12, 2022
@spiffcs spiffcs self-assigned this Jul 12, 2022
@spiffcs spiffcs removed the status in OSS Jul 12, 2022
@spiffcs spiffcs moved this to Backlog (Pulled Forward for Priority) in OSS Jul 12, 2022
@spiffcs
Copy link
Contributor

spiffcs commented Jul 12, 2022

@Turbots while we work on a fix that possibly lowers the severity of this vulnerability in the grype feed service you can specify matches you'd like to ignore via the ignore configuration linked below:
https://github.com/anchore/grype#specifying-matches-to-ignore

If this does not work for you let me know if there are other workarounds to explore that can unblock the production gates

@joshbressers
Copy link
Contributor

This issue is a lovely example of many hurdles the current vulnerability ecosystem suffers from (on a side note, the Cloud Security Alliance has a project called GSD to try to discuss and solve many of these problems)

I'm going to ignore the discussion of if this should or shouldn't have an ID. I think that's more art than science at this point.

But I do think we can all agree the severity is pretty 🍌

This is not a critical issue by itself. Unfortunately CVSS is not capable of scoring something like this because the ID is completely dependent on the use case of a framework. This is like demanding a lumber yard tell you how strong of an earthquake a stack wood can withstand if you build a house with it.

I would give this a CVSS3.1 score of 0
AV:N/AC:H/PR:H/UI:N/S:U/C:N/I:N/A:N
Not because it deserves a 0, but because the severity is low and this is the only intellectually honest way to score this.

That said, there is value in having this ID around even as low. It provides an opportunity for spring users to take steps to ensure they are not deserializing untrusted data.

I would prefer we fix the severity instead of completely removing the ID from our data set.

If anyone has opinions on this matter please speak up, this will help define future policy decisions around the Grype data

@spiffcs spiffcs removed their assignment Jul 13, 2022
@spiffcs spiffcs moved this from Backlog (Pulled Forward for Priority) to In Progress (Actively Resolving) in OSS Jul 18, 2022
@spiffcs spiffcs self-assigned this Jul 18, 2022
@spiffcs spiffcs moved this from In Progress (Actively Resolving) to Triage (Comments or Progress Made) in OSS Jul 19, 2022
@spiffcs spiffcs moved this from Parking Lot (Comments or Progress) to False Positives in OSS Aug 25, 2022
@OfriOuzan
Copy link

OfriOuzan commented Oct 2, 2022

We encountered the same issue on the following environment
What happened:
In a Vulnerability Scanner Benchmark Research we are conducting, we executed Grype on 20 different containers and found out that Grype has multiple False Positives.
What you expected to happen:
We expected Grype not to report on these CVEs.
How to reproduce it (as minimally and precisely as possible):
Install the Docker Images (from the links below) and execute Grype using the following command:
grype <container_name> —-output json > <output_file_path>

  • Output of grype version:
    Application: grype
    Version: 0.41.0
    Syft Version: v0.50.0
    BuildDate: 2022-07-06T15:20:18Z
    GitCommit: 0e0a9d9
    GitDescription: v0.41.0
    Platform: linux/amd64
    GoVersion: go1.18.3
    Compiler: gc
    Supported DB Schema: 4

Jenkins

@spiffcs spiffcs removed their assignment Oct 13, 2022
@Schwaller
Copy link

This affects everybody that uses spring ... please fix it soon. @OfriOuzan great analysis!

@willmurphyscode
Copy link
Contributor

Hi all,

Since this issue was opened, Grype has switched from using CVE data to using GHSA data by default for Java packages.

We still find the GHSA version of this issue, GHSA-4wrc-f8pq-fpqp, and it is still marked as critical. From Grype's perspective, we are correctly reporting what the upstream data source says.

But, since we use GHSA now, it's possible for users to seek to correct the data by raising an issue or PR against https://github.com/github/advisory-database. If such a correction is accepted up stream, Grype will results will reflect the corrected data after about 24 hours.

@willmurphyscode willmurphyscode closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
@github-project-automation github-project-automation bot moved this to Done in OSS Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working false-positive
Projects
Archived in project
Development

No branches or pull requests

7 participants