Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "make integration" target assumes that skopeo will be available on PATH, but this wasn't documented. Install it during bootstrap when other utilities are installed. (See ./test/integration/utils_test.go:50). Include a sample skopeo policy.json, otherwise skopeo will look for a missing policy doc a /etc/containers/policy.json and exit with an error. The sample policy document matches the one included by default with "brew install skopeo".
Discussion
./test/integration/test-fixtures/skopeo-policy.json
the right place for this file?skopeo-policy.json
what we want?skopeo
on path if it's available? IMO no, since it would make the test depend more on the environment where it was run, but wanted to call out this behavior change.repoRoot
from elsewhere in the test suite. Is it worth extracting anywhere?Why?
On current main, initial test run fails without skopeo:
Testing
On this branch,
./repro.sh
(not committed; just part of working on the issue) passes, but on main, it fails.