Add support for Syft IDs in JSON output #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
wagoodman
reviewed
May 5, 2023
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
wagoodman
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grype's JSON output has been missing the
idfield on packages.This PR is a "quick win" / "first iteration" on #1265 — supporting the specific case of Grype scanning a Syft-format SBOM.
This PR also makes an adjustment to how test input data is generated: now that we're comparing IDs, it was a problem that Grype's presenter test code was generating random UUIDs for package IDs on every run. My suggested fix for this is to lean on Syft's deterministic ID generation mechanism instead, but I defer to any ideas you all have!
Also, let me know if you'd like to see additional tests here, such as scanning a Syft JSON test fixture!
cc: @wagoodman