chore: exclude yardstick store from filename rules #1440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables "make lint" to be run after "make quality". Previously, the linter rules that prohibit ":" in any filename would fail if the yardstick or vulnerability-match-labels directories had been initialized (e.g. if "make quality" had been run), since they have filenames like "sha256:abcd" in them. Exclude them from this lint, since they are not go files.
Manual testing done
Test case where repo has yardstick state, and thus files with ":":
make
in test/quality to get some yardstick state in the workspace:
in the name:find . | grep -e ":" | wc -l
prints ~17k.make lint
from the root of this workspace; it succeeds.Running
make lint
on main, before this change, if the yardstick state is initialized, fails like this:Test case where this state hasn't existed (to make sure the subshell exiting differently because of the grep or whatever doesn't break something):
exits zero.