fix: only warn missing CPEs if CPEs wanted #1710
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a warning would be logged about missing CPEs even when processing packages for which CPEs would never be generated. Instead, return a specific error when attempting to match by CPEs on a package with no CPEs.
This change improves the user experience in 2 ways:
But with the following tradeoff:
Fixes #1634
Example runs
Before, even with CPE matching disabled
❯ grype cgr.dev/chainguard/go ... [0009] WARN some package(s) are missing CPEs. This may result in missing vulnerabilities. You may autogenerate these using: --add-cpes-if-none NAME INSTALLED FIXED-IN TYPE VULNERABILITY SEVERITY ...
After this change, with CPE matching disabled, no warning is printed.
After this change, if when Grype attempts to match on a package by CPEs that has no CPEs, the flag is still suggested: