Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure all chars are replaced, fix issue 396 #416

Closed
wants to merge 2 commits into from
Closed

make sure all chars are replaced, fix issue 396 #416

wants to merge 2 commits into from

Conversation

lts-po
Copy link
Contributor

@lts-po lts-po commented May 3, 2023

This should fix problems with artifact names containing invalid characters:
"Error: Artifact name is not valid: xyz-rrr:0.1.2-dev.spdx.json. Contains the following character: Colon :"

#396

@kzantow
Copy link
Contributor

kzantow commented May 3, 2023

Hi -- this looks like a good change but a couple things:

  • Could you sign-off your commits?
  • The files in dist/* need to be regenerated (this would typically happen automatically if you ran npm install) you can manually run this with npm run package
  • Would you be able to add a very simple test for this so we can avoid regressions?

lts-po and others added 2 commits May 3, 2023 16:50
Signed-off-by: lts-po <philip@supernetworks.org>
Signed-off-by: lts-po <philip@supernetworks.org>
@lts-po
Copy link
Contributor Author

lts-po commented May 3, 2023

@kzantow commits should be signed off now, added test & pushed dist.

@kzantow
Copy link
Contributor

kzantow commented May 3, 2023

@lts-po -- it looks like there are still commits which are not signed off, maybe just squash them all, sign and force-push again?

@lts-po lts-po closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants