Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update codeql-analysis for go 1.21 #2108

Merged
merged 3 commits into from
Sep 7, 2023
Merged

fix: update codeql-analysis for go 1.21 #2108

merged 3 commits into from
Sep 7, 2023

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Sep 7, 2023 •
edited
Loading

Summary

Now that syft uses Golang v1.21 a setup go action is needed for codeql to function correctly:
github/codeql#13867 (comment)
github/codeql#13867 (comment)

This PR Cleans up the codeql and SA failures we see on main

@spiffcs
fix: update codeql-analysis for go 1.21
c7bcb39 
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs
Merge branch 'main' into code-ql-go-update
3d4e2b6 
* main:
  Bump the golang.org/x/exp dependency and fix a build breakage. (#2088)
  chore(deps): bump actions/checkout from 3 to 4 (#2094)
  chore(deps): bump github.com/gkampitakis/go-snaps from 0.4.7 to 0.4.10 (#2106)

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz%0A                                                              │ ./.tmp/benchmark-fa14198.txt │%0A                                                              │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       12.11m ±  2%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        692.2µ ±  1%25%0AImagePackageCatalogers/binary-cataloger-2                                       209.3µ ±  1%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       596.3µ ±  2%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   22.21µ ±  3%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             96.61µ ±  2%25%0AImagePackageCatalogers/java-cataloger-2                                         21.96m ± 19%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         92.74µ ±  1%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           373.5µ ±  1%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    274.0µ ±  4%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       776.3µ ±  3%25%0AImagePackageCatalogers/portage-cataloger-2                                      480.3µ ±  3%25%0AImagePackageCatalogers/python-package-cataloger-2                               3.356m ±  2%25%0AImagePackageCatalogers/r-package-cataloger-2                                    198.1µ ±  3%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       545.9µ ±  5%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 901.0µ ±  1%25%0AImagePackageCatalogers/sbom-cataloger-2                                         118.4µ ±  1%25%0Ageomean                                                                         496.4µ%0A%0A                                                              │ ./.tmp/benchmark-fa14198.txt │%0A                                                              │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       5.066Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        181.6Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                       30.76Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       139.8Ki ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   3.695Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             9.281Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                         3.314Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         8.000Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           82.87Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    38.38Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       152.6Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                      108.3Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                               982.7Ki ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                    42.37Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       165.4Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 122.5Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                         14.20Ki ± 0%25%0Ageomean                                                                         91.89Ki%0A%0A                                                              │ ./.tmp/benchmark-fa14198.txt │%0A                                                              │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                        74.97k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                         3.670k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                         866.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                        2.721k ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                     132.0 ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                               270.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                          43.40k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                           218.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                            1.203k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                      751.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                        3.461k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                       2.011k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                                15.76k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                      782.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                        2.877k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                  2.185k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                           394.0 ± 0%25%0Ageomean                                                                          1.870k

@spiffcs
nit: remove comment
307c52e 
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs merged commit 3842d28 into main Sep 7, 2023
9 checks passed
@spiffcs spiffcs deleted the code-ql-go-update branch September 7, 2023 19:54
@chenrui333 chenrui333 mentioned this pull request Sep 11, 2023
Merged
This was referenced Sep 12, 2023
Closed
Closed
Open
Open
This was referenced Sep 21, 2023
Closed
Closed
Open
@jedevc jedevc mentioned this pull request Nov 6, 2023
Merged
@jedevc jedevc mentioned this pull request Dec 18, 2023
Merged
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@spiffcs
fix: update codeql-analysis for go 1.21 (anchore#2108)
d4f7cd5 
* fix: update codeql-analysis for go 1.21

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>

* nit: remove comment

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>

---------

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spiffcs @wagoodman