Syft does not handle the case of parsing a jar with multiple poms #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coheigea
force-pushed
the
coheigea/multiple-poms
branch
2 times, most recently
from
b9621dc
to
e5b90b1
Compare
|
@wagoodman Rebased this after #2220 was merged, if you could take a look please? |
Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
coheigea
force-pushed
the
coheigea/multiple-poms
branch
from
e5b90b1
to
1940b7e
Compare
|
rebased again |
|
@coheigea - thanks for rebasing this! Since this code change didn't break any tests I think I'm going to take your example package and write a quick unit test that validates the change and keeps us covered going forward. Let me see if I can get that in today and then I'll 🟢 and merge this one too =) |
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
wagoodman
reviewed
Nov 1, 2023
wagoodman
approved these changes
Nov 1, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
anchore#2231) --------- Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org> Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> Co-authored-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restriction to only parse one pom.xml / pom.properties in the archive fails for certain jars that shade multiple dependencies into the jar. For example:
https://repo1.maven.org/maven2/org/apache/directory/api/api-all/2.0.0/
which has:
Syft does end up finding the license for api-all anyway, because of a LICENSE file included in the archive, but otherwise wouldn't find a license as it's not proceeding to the loop to find the correct pom.