Refine license search from groupIDFromJavaMetadata to account for artfactId in the groupId #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving the artfactId in the groupId Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
spiffcs
approved these changes
Nov 15, 2023
wagoodman
changed the title
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…ving the artfactId in the groupId (anchore#2313) Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the groupId that is obtained from groupIDFromJavaMetadata is not quite correct, in that it contains some version of the artifactId in the path. For example:
https://repo1.maven.org/maven2/com/jayway/jsonpath/json-path/2.4.0/
Syft doesn't find a license because the groupId is com.jayway.jsonpath.json-path instead of com.jayway.jsonpath. Also:
https://repo1.maven.org/maven2/com/google/api/api-common/2.2.0/
Syft doesn't find a license because the groupId is com.google.api.apicommon instead of com.google.api.
The PR falls back to stripping the last package name from the groupId to see if it can find a pom from Maven central. Licenses are found correctly for the two examples above.