Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): improve identification for io.projectreactor.netty artifacts #2378

Merged

Conversation

westonsteimel
Copy link
Contributor

@westonsteimel westonsteimel commented Nov 30, 2023

grype fails to match vulns such as GHSA-q24v-hpg3-v3jp because syft generates an incorrect groupid (io.projectreactor.netty.reactor-netty-http rather than just io.projectreactor.netty) for reactor-netty* artifacts. This adds a manual mapping to the correct expected maven namespace for these artifacts when no better source of identification is available

Signed-off-by: Weston Steimel <weston.steimel@proton.me>
@westonsteimel westonsteimel requested a review from a team November 30, 2023 21:36
@westonsteimel westonsteimel added the bug Something isn't working label Nov 30, 2023
@westonsteimel westonsteimel enabled auto-merge (squash) November 30, 2023 21:43
@westonsteimel westonsteimel merged commit facbc48 into main Dec 1, 2023
10 checks passed
@westonsteimel westonsteimel deleted the improve-reactor-netty-java-artifact-identification branch December 1, 2023 12:09
spiffcs added a commit to coheigea/syft that referenced this pull request Dec 5, 2023
* main: (40 commits)
  chore(deps): bump anchore/sbom-action from 0.15.0 to 0.15.1 (anchore#2392)
  Retrieve remote licenses using pom.properties when there is no pom.xml (anchore#2315)
  fix(java): improve identification for org.apache.tapestry artifacts (anchore#2384)
  fix(java): improve identification for io.ratpack artifacts (anchore#2379)
  fix(java): improve identification for org.apache.cassandra artifacts (anchore#2386)
  fix(java): improve identification for org.neo4j.procedure artifacts (anchore#2388)
  fix: bump fangs for ptr summarize fix (anchore#2387)
  fix(java): improve identification for org.elasticsearch artifacts (anchore#2383)
  fix(java): improve identification for org.apache.geode artifacts (anchore#2382)
  fix(java): improve identification for org.apache.tomcat.embed artifacts (anchore#2381)
  fix(java): improve identification for io.projectreactor.netty artifacts (anchore#2378)
  fix(java): improve identification for org.eclipse.platform artifacts (anchore#2349)
  Generalize UI events for cataloging tasks (anchore#2369)
  chore(deps): update tools to latest versions (anchore#2376)
  chore(deps): bump github.com/google/go-containerregistry (anchore#2377)
  chore: fix tests failing due to Mac Rosetta cache (anchore#2374)
  fix: improve dotnet portable executable identification (anchore#2133)
  fix file metadata cataloger to use resolved locations (anchore#2370)
  fix: logging level for parsing potential PE files (anchore#2367)
  only remove breaking-change label when there are schema changes (anchore#2371)
  ...

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
…ts (anchore#2378)

Signed-off-by: Weston Steimel <weston.steimel@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants