Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dotnet): improve forming dotnet package names #2569

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(dotnet): improve forming dotnet package names #2569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion syft/pkg/cataloger/dotnet/parse_dotnet_portable_executable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ var (
func findName(versionResources map[string]string) string {
// PE files found in the wild _not_ authored by Microsoft seem to use ProductName as a clear
// identifier of the software
nameFields := []string{"ProductName", "FileDescription", "InternalName", "OriginalFilename"}
nameFields := []string{"InternalName", "OriginalFilename", "ProductName", "FileDescription"}

if isMicrosoft(versionResources) {
// Microsoft seems to be consistent using the FileDescription, with a few that are blank and have
Expand All @@ -188,6 +188,9 @@ func findName(versionResources map[string]string) string {
if value == "" {
continue
}

value = strings.TrimSuffix(strings.ReplaceAll(value, " ", "."), ".dll")

return value
}

Expand Down
Loading