Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close sqlite driver after testing sqlite availability #2922

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

ttc0419
Copy link
Contributor

@ttc0419 ttc0419 commented Jun 3, 2024

For long running programs, opening a sql connection without closing it will cause go routine leaks. Close sql driver after testing sqlite availability.

Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 🙌

@wagoodman wagoodman added the bug Something isn't working label Jun 3, 2024
@wagoodman wagoodman enabled auto-merge (squash) June 3, 2024 14:19
auto-merge was automatically disabled June 3, 2024 14:25

Head branch was pushed to by a user without write access

Signed-off-by: William Tang <ttc0419@outlook.com>
@ttc0419 ttc0419 requested a review from wagoodman June 3, 2024 14:30
@wagoodman wagoodman enabled auto-merge (squash) June 3, 2024 14:33
@wagoodman wagoodman merged commit fe0b78b into anchore:main Jun 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants