Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for app update #88

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Add check for app update #88

merged 3 commits into from
Jul 21, 2020

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Jul 18, 2020 •
edited
Loading

  • Primarily adds application update on startup, which is configurable to be toggled either off or on (but not change the URL)
  • Refactors the version to be internally accessible and adds more build information (to be later filled in by goreleaser)
  • Fixes ETUI error handling
  • Refactors return of errors from main()
  • Tightens cobra validation of positional args, which closes Add user image error handling  #37

Closes #55

alfredodeza
alfredodeza suggested changes Jul 20, 2020
View reviewed changes
cmd/root.go Outdated Show resolved Hide resolved
internal/ui/etui/ephemeral_tui.go Outdated Show resolved Hide resolved
internal/version/update_test.go Show resolved Hide resolved
@wagoodman wagoodman mentioned this pull request Jul 20, 2020
Merged
@wagoodman wagoodman merged commit 7ebb9f4 into master Jul 21, 2020
@wagoodman wagoodman deleted the add-update-check branch July 21, 2020 16:02
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
Add check for app update (anchore#88)
ed73b0c 
* add check for app update; fix ETUI error handling

* validate user args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfredodeza alfredodeza alfredodeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update check Add user image error handling
2 participants
@wagoodman @alfredodeza