Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue - Option to enable specific language or ecosystem cataloger #888

Closed
wants to merge 1 commit into from

Conversation

houdini91
Copy link
Contributor

Hi PR is the continue work on #843.

  • Rename flag from enable-catalogers to catalogers configuration
  • Add -C --cataloger command line argument.
  • Flags support remove of cataloger suffix.
syft packages busybox:latest -C java-cataloger -C apkdb
  • Added cataloger-group flag which selects the group catalogers.
    Supported group Index, installed, all.
  • Empty group - select default group ( Dir:Index, Image:installed)
syft packages busybox:latest -C javascript-lock-cataloger --cataloger-group all -vv
syft packages dir:./cmd --cataloger-group install -vv

@houdini91 houdini91 force-pushed the cataloger_control branch 3 times, most recently from b18071d to d30eb00 Compare March 17, 2022 13:53
Signed-off-by: houdini91 <mdstrauss91@gmail.com>
@spiffcs
Copy link
Contributor

spiffcs commented May 26, 2022

@houdini91 I have not forgotten about this PR. I just added it to our internal board now so I'll start working on getting you a review as soon as I can carve out some time.

@spiffcs spiffcs self-assigned this May 26, 2022
@spiffcs
Copy link
Contributor

spiffcs commented Jun 14, 2022

Just a quick update - it looks like @wagoodman has pulled in the configuration cataloger work under joint issue #1039 with the PR via #1038.

@spiffcs spiffcs assigned wagoodman and unassigned spiffcs Jun 23, 2022
@tgerla tgerla assigned tgerla and unassigned wagoodman Aug 11, 2022
@wagoodman
Copy link
Contributor

@houdini91 I'm going to close this PR since we have another PR that hooks into the new API proposed in #558 (#1383). The new PR lacks some features from this PR (such as cataloger groups) but this PR would essentially need to be rewritten based on the upcoming changes.

If you're still interested in some of these features please feel free to reach out and I'd be happy to work with you!

@wagoodman wagoodman closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants