Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OS in release workflow #223

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Update OS in release workflow #223

merged 2 commits into from
Jun 29, 2023

Conversation

wagoodman
Copy link
Contributor

This makes the OS version consistent in the validations and release pipelines (important when sharing a cache between workflows). I can't seem to find a way to get the ubuntu-20.04 name/version info from the github runner context (seems to not exist actions/runner#2527 ) but that would be ideal to bake into the cache key as well.

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman changed the title Update os in release workflow Update OS in release workflow Jun 29, 2023
@wagoodman wagoodman enabled auto-merge (squash) June 29, 2023 12:45
@wagoodman wagoodman merged commit cf77840 into main Jun 29, 2023
@wagoodman wagoodman deleted the update-os branch June 29, 2023 12:55
@kolyshkin
Copy link

I can't seem to find a way to get the ubuntu-20.04 name/version info from the github runner context (seems to not exist actions/runner#2527 ) but that would be ideal to bake into the cache key as well.

There is apparently ${process.env.ImageOS} (see actions/setup-go#383), which resolves to e.g. ubuntu20 or ubuntu22 (which, I guess, is OK since GHA only support LTS releases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants