Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
For my smart home project, as I expanded it, I began to notice a few odd behaviours of my I2C-connected components.
Upon analysis with my Salea, I noticed two things:
The former point was a simple manner of rewriting the
read()
code to not always execute thewrite
function.The second point was a lack of synchronisation between multiple threads, allowing different Threads to simultaneously write to
@device
, thusly confusing what data and address were sent where.The mutex I added makes sure that only one Thread can ever access the
@device
between setting address, writing and reading. It can additionally be accessed and locked manually, to perform multiple consecutive read or write operations to single or multiple devices.This change is