-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#164798298: Enable users favorite an article #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickf949
requested review from
Genza999,
inno-asiimwe,
e-ian and
anyatibrian
April 17, 2019 03:49
patrickf949
force-pushed
the
ft-users-favorite-articles-164798298
branch
from
April 17, 2019 04:38
a88db22
to
010bc53
Compare
patrickf949
force-pushed
the
ft-users-favorite-articles-164798298
branch
from
April 17, 2019 09:47
010bc53
to
48bbcb5
Compare
patrickf949
force-pushed
the
ft-users-favorite-articles-164798298
branch
from
April 17, 2019 09:56
48bbcb5
to
cffdd45
Compare
patrickf949
force-pushed
the
ft-users-favorite-articles-164798298
branch
from
April 17, 2019 10:05
cffdd45
to
f18b1b6
Compare
patrickf949
force-pushed
the
ft-users-favorite-articles-164798298
branch
from
April 17, 2019 10:53
f18b1b6
to
ff5ac9d
Compare
- Add models for favoriting and unfavoriting an article - Add serializers to handle favoriting and unfavoriting of an article - Add endpoints for manipulating favoriting and unfavoriting article - Add view for users to retrieve all fans of an article [Maintains #164798298]
patrickf949
force-pushed
the
ft-users-favorite-articles-164798298
branch
from
April 17, 2019 11:20
ff5ac9d
to
e09fe50
Compare
e-ian
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
inno-asiimwe
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables a user favorite an article on authors haven
Description of tasks to be done
of an article
article
of an article
How this should be manually tested?
Run the server and get to the swagger-docs on your browser using this link
After registering and logging in a user, create a few articles and favorite them using the post method to access the endpoint
Screenshots
After favoriting an article expect a result like this
Fans of an article are returned this way
An article is returned with the number of times it has been favorited
A user profile is returned with the articles he has favorited before
Unfavoriting an article returns a message similar to this
#164798298