Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#164798210 User should be able to favorite an article #23

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

ezrogha
Copy link
Contributor

@ezrogha ezrogha commented Apr 11, 2019

What does this PR do?

User should be able to favorite an article

Description of Task to be completed?

User should be in position to favorite, unfavorite and also view list of favorited articles

How should this be manually tested?

Fetch this branch git fetch origin ft-user-can-favorite-articles-164798210
Checkout to the branch git checkout ft-user-can-favorite-articles-164798210
Run pipenv shell
Run python manage.py migrate
Run python manage.py runserver

What are the relevant pivotal tracker stories?

#164798210

Screenshots (if appropriate)

Screenshot 2019-04-12 at 08 39 18

Screenshot 2019-04-12 at 08 39 55

Postman Collection

Run in Postman

@ezrogha ezrogha force-pushed the ft-user-can-favorite-articles-164798210 branch 3 times, most recently from c93b017 to 406105f Compare April 11, 2019 09:24
@ezrogha ezrogha force-pushed the ft-user-can-favorite-articles-164798210 branch from 406105f to 9659529 Compare April 11, 2019 09:28
@ezrogha ezrogha removed the finished label Apr 11, 2019
@ezrogha ezrogha force-pushed the ft-user-can-favorite-articles-164798210 branch from 9659529 to d3dda8d Compare April 12, 2019 05:26
@ezrogha ezrogha force-pushed the ft-user-can-favorite-articles-164798210 branch from 0a49404 to 5ac2dad Compare April 12, 2019 05:54
dannylwe
dannylwe previously approved these changes Apr 12, 2019
dorothyas
dorothyas previously approved these changes Apr 12, 2019
@ezrogha ezrogha changed the title #164798210 User should be able to favorite an article: #164798210 User should be able to favorite an article Apr 12, 2019
felixkiryowa
felixkiryowa previously approved these changes Apr 12, 2019
@ezrogha ezrogha dismissed stale reviews from felixkiryowa, dorothyas, and dannylwe via fc169cf April 12, 2019 09:12
@ezrogha ezrogha force-pushed the ft-user-can-favorite-articles-164798210 branch from 5ac2dad to fc169cf Compare April 12, 2019 09:12
@dorothyas dorothyas self-requested a review April 12, 2019 09:17
dorothyas
dorothyas previously approved these changes Apr 12, 2019
dannylwe
dannylwe previously approved these changes Apr 12, 2019
@ezrogha ezrogha dismissed stale reviews from dannylwe and dorothyas via 9bbbcad April 12, 2019 09:27
@ezrogha ezrogha force-pushed the ft-user-can-favorite-articles-164798210 branch from fc169cf to 9bbbcad Compare April 12, 2019 09:27
@ezrogha ezrogha force-pushed the ft-user-can-favorite-articles-164798210 branch from 9bbbcad to 1460dd4 Compare April 12, 2019 09:34
  - User can favorite article
  - User can unfavorite article
  - User can view favorite list

[Maintains #164798210]
@ezrogha ezrogha force-pushed the ft-user-can-favorite-articles-164798210 branch from 1460dd4 to 3a35f37 Compare April 12, 2019 09:41
@dannylwe dannylwe self-requested a review April 12, 2019 09:47
@dorothyas dorothyas self-requested a review April 12, 2019 09:48
Copy link
Contributor

@ja-odur ja-odur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ja-odur ja-odur merged commit 5d5314d into develop Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants