-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#164798210 User should be able to favorite an article #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrogha
force-pushed
the
ft-user-can-favorite-articles-164798210
branch
3 times, most recently
from
April 11, 2019 09:24
c93b017
to
406105f
Compare
ezrogha
force-pushed
the
ft-user-can-favorite-articles-164798210
branch
from
April 11, 2019 09:28
406105f
to
9659529
Compare
ezrogha
force-pushed
the
ft-user-can-favorite-articles-164798210
branch
from
April 12, 2019 05:26
9659529
to
d3dda8d
Compare
ezrogha
force-pushed
the
ft-user-can-favorite-articles-164798210
branch
from
April 12, 2019 05:54
0a49404
to
5ac2dad
Compare
dannylwe
previously approved these changes
Apr 12, 2019
dorothyas
previously approved these changes
Apr 12, 2019
ezrogha
changed the title
#164798210 User should be able to favorite an article:
#164798210 User should be able to favorite an article
Apr 12, 2019
felixkiryowa
previously approved these changes
Apr 12, 2019
ezrogha
dismissed stale reviews from felixkiryowa, dorothyas, and dannylwe
via
April 12, 2019 09:12
fc169cf
ezrogha
force-pushed
the
ft-user-can-favorite-articles-164798210
branch
from
April 12, 2019 09:12
5ac2dad
to
fc169cf
Compare
dorothyas
previously approved these changes
Apr 12, 2019
dannylwe
previously approved these changes
Apr 12, 2019
ezrogha
force-pushed
the
ft-user-can-favorite-articles-164798210
branch
from
April 12, 2019 09:27
fc169cf
to
9bbbcad
Compare
ezrogha
force-pushed
the
ft-user-can-favorite-articles-164798210
branch
from
April 12, 2019 09:34
9bbbcad
to
1460dd4
Compare
- User can favorite article - User can unfavorite article - User can view favorite list [Maintains #164798210]
ezrogha
force-pushed
the
ft-user-can-favorite-articles-164798210
branch
from
April 12, 2019 09:41
1460dd4
to
3a35f37
Compare
felixkiryowa
approved these changes
Apr 12, 2019
dannylwe
approved these changes
Apr 12, 2019
ja-odur
approved these changes
Apr 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
User should be able to favorite an article
Description of Task to be completed?
User should be in position to favorite, unfavorite and also view list of favorited articles
How should this be manually tested?
Fetch this branch
git fetch origin ft-user-can-favorite-articles-164798210
Checkout to the branch
git checkout ft-user-can-favorite-articles-164798210
Run
pipenv shell
Run
python manage.py migrate
Run
python manage.py runserver
What are the relevant pivotal tracker stories?
#164798210
Screenshots (if appropriate)
Postman Collection