Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#161382408] share articles via email, facebbok and twitter #69

Merged
merged 1 commit into from
Nov 15, 2018
Merged

[#161382408] share articles via email, facebbok and twitter #69

merged 1 commit into from
Nov 15, 2018

Conversation

emukungu
Copy link
Contributor

@emukungu emukungu commented Nov 14, 2018 •
edited
Loading

What does this PR do?

  • Enables Users to share articles across different channels

Description of Task to be completed?

  • As an authenticated user, I should be able to share articles;
    both mine and others via email and social media platforms

How should this be manually tested?

  • Clone the repository.
  • Run python manage.py makemigrations
  • Run python manage.py migrate
  • Run python manage.py runserver
  • open localhost:8000 in postman.
  • Create a users with POST api/users/
  • Login the user in with POST api/users/login/ to get the token
  • Use POST api/articles/ to create an article with the logged in user
  • Use POST api/articles/<slug>/twitter to share the article on twitter by the logged in user
  • Use POST api/articles/<slug>/facebook to share the article on facebook by the logged in user
  • Use POST api/articles/<slug>/email to share the article to logged in user email

What are the relevant pivotal tracker stories?

  • #161382408

Screenshots

Share article via email
email

Share article via facebook
facebook

Share article via twitter
twitter

@coveralls
Copy link

coveralls commented Nov 14, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 96.31% when pulling f9784d6 on ft-users-able-share-articles-161382408 into df28b6c on develop.

@emukungu emukungu force-pushed the ft-users-able-share-articles-161382408 branch from 242c9fb to fbada6e Compare November 14, 2018 15:41
[#161382408]share articles via email, facebbok and twitter
f9784d6 
refactor the codebase.

allow a user to share articles

[#161382408] share articles via email,facebook, twitter

remove environment files

[#161382408]add tests to sharing articles

[#161382408]add more tests to sharing articles

add descriptive names to test responses

fix conflicts

fix conflicts

refactor codebase

refactor codebase

refactor codebase

refactor codebase

refactor codebase
@emukungu emukungu force-pushed the ft-users-able-share-articles-161382408 branch from fbada6e to f9784d6 Compare November 14, 2018 15:51
@emukungu emukungu requested review from cdvx, johnkegz, joshNic and malep2007 and removed request for cdvx and johnkegz November 14, 2018 15:52
cdvx
cdvx approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@cdvx cdvx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good @emukungu

@malep2007 malep2007 merged commit 50fb50f into develop Nov 15, 2018
cdvx pushed a commit that referenced this pull request Nov 15, 2018
@API-Imperfect
Setup and add Basic Authentication
eb076fd 
Fix installation instructions in README

Fix README

Add comment count to multiple comments

Updated error text

Fixed typo

Fixed typo

* Updated Django to version 2.0.6

* Upgraded Django and Solved Dependencies

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* Added .travis.yml config file

* #159135657 Integrate TravisCI with readme badge

* #159135657 Integrate TravisCI with readme badge

* #159135657 Integrate TravisCI with readme badge

Revert "#159135657 Integrate TravisCI with readme badge (#1)" (#2)

This reverts commit 2389027.

[Started Chore #161415101] Upgrade Django version from 2.1 to 2.1.2

[ch-#161382378] Ugrade Django version from 1.10 to 2.1

Revert "[ch-#161382378] Ugrade Django version from 1.10 to 2.1"

[ch-#161382378] Ugrade Django version from 1.10 to 2.1

Revert "[ch-#161382378] Ugrade Django version from 1.10 to 2.1"

Revert "Develop"

Ch integrate travis ci badge 161382382 (#2) (#9)

* [chore #161382382] add travis to repo

* [chore #161382382] add sample test to repo

* [chore #161382382] add python dependencies

* [chore #161382382] add travis badge to readme

* [chore #161382382] remove unssupported python version

[Chore #161415101] Upgrade django from 1.10 to 2.1.2 (#19)

Fix travis ci #161382382 (#21)

* [chore #161382382] add before script to travis

* [chore #161382382] add travis badge to readme file

* [chore #161382382] add travis badge

* ignore vscode configs

* [chore #161382382] add travis badge

* [chore #161382386] add coveralls reporting

* [chore #161382386] add coveralls reporting

* [chore #161382382] fix travis error

* [chore #161382382] update dependencies

* [chore #161382382] ignore migrations

* [chore #161382382] add latest project dependencies

* [chore #161382382] fix intial app errors

* [chore #161382382] revert to intial configs

* [chore #161382382] update test configs for travis

* [chore #161382382] fix merge conflicts

* [chore #161382386] add coveralls reporting

* [chore #161382383] Set up postgresql as db engine

* [chore] Fetch updates from develop

* [chore #161382383] Configure postresql as DB engine

* Ch integrate travis ci badge 161382382 (#2)

* [chore #161382382] add travis to repo

* [chore #161382382] add sample test to repo

* [chore #161382382] add python dependencies

* [chore #161382382] add travis badge to readme

* [chore #161382382] remove unssupported python version

* Develop (#13)

* [ch-#161382378] Ugrade Django version from 1.10 to 2.1

* Revert "[ch-#161382378] Ugrade Django version from 1.10 to 2.1"

* [Chore #161383178] Add Code Climate badge in README.

* Revert "Develop"

* Ch integrate travis ci badge 161382382 (#2) (#9)

* [chore #161382382] add travis to repo

* [chore #161382382] add sample test to repo

* [chore #161382382] add python dependencies

* [chore #161382382] add travis badge to readme

* [chore #161382382] remove unssupported python version

* Ch integrate travis ci badge 161382382 (#6)

* [chore #161382382] add travis to repo

* [chore #161382382] add sample test to repo

* [chore #161382382] add python dependencies

* [chore #161382382] add travis badge to readme

* [chore #161382382] remove unssupported python version

* Revert "Develop (#13)" (#15)

This reverts commit bf08440.

* Ch upgrade from django 2.1 to django 2.1.2 161415101 (#17)

* [ch-#161382378] Ugrade Django version from 1.10 to 2.1

* Revert "[ch-#161382378] Ugrade Django version from 1.10 to 2.1"

* [Chore #161383178] Add Code Climate badge in README.

* Revert "Develop"

* Ch integrate travis ci badge 161382382 (#2) (#9)

* [chore #161382382] add travis to repo

* [chore #161382382] add sample test to repo

* [chore #161382382] add python dependencies

* [chore #161382382] add travis badge to readme

* [chore #161382382] remove unssupported python version

* Ch integrate travis ci badge 161382382 (#6)

* [chore #161382382] add travis to repo

* [chore #161382382] add sample test to repo

* [chore #161382382] add python dependencies

* [chore #161382382] add travis badge to readme

* [chore #161382382] remove unssupported python version

* Ch integrate travis ci badge 161382382 (#2) (#16)

* [chore #161382382] add travis to repo

* [chore #161382382] add sample test to repo

* [chore #161382382] add python dependencies

* [chore #161382382] add travis badge to readme

* [chore #161382382] remove unssupported python version

* [Chore #161415101] Upgrade django from 1.10 to 2.1.2

* [chore #161382383] Update requirements.txt

* [chore #161382383] Update .travis.yml

* [chore #161382383] Update .travis.yml

* [chore #161382383] Update tests

* [chore #161382383] Update tests

* [chore #161382383] Fix travis build

* [chore #161382383] Fix travis build

Ch fix coveralls badge (#28)

[Started ft #161382387] adds swagger (#29)

* Update README.md

[ft #161382387] changes class-based views to generic views

* [ft #161382387] changes class-based views to generic views

[chore #61382390] refactor tests and user validation (#34)

[Started Ch #161652871] changes from from djangorest-swagger to drf-yasg (#37)

Delete 0001_initial.py (#39)

Deleting this migration file will fix the issue of inconsistent migrations histories such that when migrations are run on Heroku, it picks ups on the new changes to the database and hence the deployed application includes all the new features merged to develop.

* ch[#161711202]:Put password and email into environmental variables.

* ch[#161711202]:Put password and email into environmental variables.

Update README.md

Update README.md

Ft user create comments 161382397 (#51)

Chore fix heroku Deploy (#57)

send an a password reset email using gmail smtp (#58)

rate an article (#59)

[ft #161382403] adds article tags (#61)

* [ft #161382403] adds article tags

allow a user to follow another user (#62)

[ft #161382405] Add filters to search articles (#63)

ft[#161382400]:Users should be able to favorite articles (#65)

[#161382408]share articles via email, facebbok and twitter (#69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshNic joshNic joshNic approved these changes

@bozicschucky bozicschucky bozicschucky approved these changes

@cdvx cdvx cdvx approved these changes

@malep2007 malep2007 Awaiting requested review from malep2007

@johnkegz johnkegz Awaiting requested review from johnkegz

Assignees
No one assigned
Labels
Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emukungu @coveralls @joshNic @bozicschucky @cdvx @malep2007