-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#161382408] share articles via email, facebbok and twitter #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emukungu
force-pushed
the
ft-users-able-share-articles-161382408
branch
from
November 14, 2018 15:41
242c9fb
to
fbada6e
Compare
refactor the codebase. allow a user to share articles [#161382408] share articles via email,facebook, twitter remove environment files [#161382408]add tests to sharing articles [#161382408]add more tests to sharing articles add descriptive names to test responses fix conflicts fix conflicts refactor codebase refactor codebase refactor codebase refactor codebase refactor codebase
emukungu
force-pushed
the
ft-users-able-share-articles-161382408
branch
from
November 14, 2018 15:51
fbada6e
to
f9784d6
Compare
joshNic
approved these changes
Nov 14, 2018
cdvx
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good @emukungu
bozicschucky
approved these changes
Nov 14, 2018
cdvx
pushed a commit
that referenced
this pull request
Nov 15, 2018
Fix installation instructions in README Fix README Add comment count to multiple comments Updated error text Fixed typo Fixed typo * Updated Django to version 2.0.6 * Upgraded Django and Solved Dependencies * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * Added .travis.yml config file * #159135657 Integrate TravisCI with readme badge * #159135657 Integrate TravisCI with readme badge * #159135657 Integrate TravisCI with readme badge Revert "#159135657 Integrate TravisCI with readme badge (#1)" (#2) This reverts commit 2389027. [Started Chore #161415101] Upgrade Django version from 2.1 to 2.1.2 [ch-#161382378] Ugrade Django version from 1.10 to 2.1 Revert "[ch-#161382378] Ugrade Django version from 1.10 to 2.1" [ch-#161382378] Ugrade Django version from 1.10 to 2.1 Revert "[ch-#161382378] Ugrade Django version from 1.10 to 2.1" Revert "Develop" Ch integrate travis ci badge 161382382 (#2) (#9) * [chore #161382382] add travis to repo * [chore #161382382] add sample test to repo * [chore #161382382] add python dependencies * [chore #161382382] add travis badge to readme * [chore #161382382] remove unssupported python version [Chore #161415101] Upgrade django from 1.10 to 2.1.2 (#19) Fix travis ci #161382382 (#21) * [chore #161382382] add before script to travis * [chore #161382382] add travis badge to readme file * [chore #161382382] add travis badge * ignore vscode configs * [chore #161382382] add travis badge * [chore #161382386] add coveralls reporting * [chore #161382386] add coveralls reporting * [chore #161382382] fix travis error * [chore #161382382] update dependencies * [chore #161382382] ignore migrations * [chore #161382382] add latest project dependencies * [chore #161382382] fix intial app errors * [chore #161382382] revert to intial configs * [chore #161382382] update test configs for travis * [chore #161382382] fix merge conflicts * [chore #161382386] add coveralls reporting * [chore #161382383] Set up postgresql as db engine * [chore] Fetch updates from develop * [chore #161382383] Configure postresql as DB engine * Ch integrate travis ci badge 161382382 (#2) * [chore #161382382] add travis to repo * [chore #161382382] add sample test to repo * [chore #161382382] add python dependencies * [chore #161382382] add travis badge to readme * [chore #161382382] remove unssupported python version * Develop (#13) * [ch-#161382378] Ugrade Django version from 1.10 to 2.1 * Revert "[ch-#161382378] Ugrade Django version from 1.10 to 2.1" * [Chore #161383178] Add Code Climate badge in README. * Revert "Develop" * Ch integrate travis ci badge 161382382 (#2) (#9) * [chore #161382382] add travis to repo * [chore #161382382] add sample test to repo * [chore #161382382] add python dependencies * [chore #161382382] add travis badge to readme * [chore #161382382] remove unssupported python version * Ch integrate travis ci badge 161382382 (#6) * [chore #161382382] add travis to repo * [chore #161382382] add sample test to repo * [chore #161382382] add python dependencies * [chore #161382382] add travis badge to readme * [chore #161382382] remove unssupported python version * Revert "Develop (#13)" (#15) This reverts commit bf08440. * Ch upgrade from django 2.1 to django 2.1.2 161415101 (#17) * [ch-#161382378] Ugrade Django version from 1.10 to 2.1 * Revert "[ch-#161382378] Ugrade Django version from 1.10 to 2.1" * [Chore #161383178] Add Code Climate badge in README. * Revert "Develop" * Ch integrate travis ci badge 161382382 (#2) (#9) * [chore #161382382] add travis to repo * [chore #161382382] add sample test to repo * [chore #161382382] add python dependencies * [chore #161382382] add travis badge to readme * [chore #161382382] remove unssupported python version * Ch integrate travis ci badge 161382382 (#6) * [chore #161382382] add travis to repo * [chore #161382382] add sample test to repo * [chore #161382382] add python dependencies * [chore #161382382] add travis badge to readme * [chore #161382382] remove unssupported python version * Ch integrate travis ci badge 161382382 (#2) (#16) * [chore #161382382] add travis to repo * [chore #161382382] add sample test to repo * [chore #161382382] add python dependencies * [chore #161382382] add travis badge to readme * [chore #161382382] remove unssupported python version * [Chore #161415101] Upgrade django from 1.10 to 2.1.2 * [chore #161382383] Update requirements.txt * [chore #161382383] Update .travis.yml * [chore #161382383] Update .travis.yml * [chore #161382383] Update tests * [chore #161382383] Update tests * [chore #161382383] Fix travis build * [chore #161382383] Fix travis build Ch fix coveralls badge (#28) [Started ft #161382387] adds swagger (#29) * Update README.md [ft #161382387] changes class-based views to generic views * [ft #161382387] changes class-based views to generic views [chore #61382390] refactor tests and user validation (#34) [Started Ch #161652871] changes from from djangorest-swagger to drf-yasg (#37) Delete 0001_initial.py (#39) Deleting this migration file will fix the issue of inconsistent migrations histories such that when migrations are run on Heroku, it picks ups on the new changes to the database and hence the deployed application includes all the new features merged to develop. * ch[#161711202]:Put password and email into environmental variables. * ch[#161711202]:Put password and email into environmental variables. Update README.md Update README.md Ft user create comments 161382397 (#51) Chore fix heroku Deploy (#57) send an a password reset email using gmail smtp (#58) rate an article (#59) [ft #161382403] adds article tags (#61) * [ft #161382403] adds article tags allow a user to follow another user (#62) [ft #161382405] Add filters to search articles (#63) ft[#161382400]:Users should be able to favorite articles (#65) [#161382408]share articles via email, facebbok and twitter (#69)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
both mine and others via email and social media platforms
How should this be manually tested?
python manage.py makemigrations
python manage.py migrate
python manage.py runserver
localhost:8000
in postman.POST api/users/
POST api/users/login/
to get the tokenPOST api/articles/
to create an article with the logged in userPOST api/articles/<slug>/twitter
to share the article on twitter by the logged in userPOST api/articles/<slug>/facebook
to share the article on facebook by the logged in userPOST api/articles/<slug>/email
to share the article to logged in user emailWhat are the relevant pivotal tracker stories?
Screenshots
Share article via email
Share article via facebook
Share article via twitter