-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#161255359 Users should be able to rate an article #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new folder in apps articles/ [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
…codeofduty into ft-articles-161255358
- Add models for articles - Add seriaizers for articles - Add views for articles - Add url routes for articles [Feature #161255358]
- User can create an article - User can fetch all articles - User can fetch a single article - User can update their article - User can delete their article - Add tests for all the CRUD functions [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
- Add models for articles - Add seriaizers for articles - Add views for articles - Add url routes for articles [Feature #161255358]
- User can create an article - User can fetch all articles - User can fetch a single article - User can update their article - User can delete their article - Add tests for all the CRUD functions [Feature #161255358]
- Rebase from develop and merge conflicts [Feature #161255358]
- Merge conflicts from origin [Feature #161255358]
- Merge conflicts from origin [Feature #161255358]
- ensure Only authenticated users should be able to provide ratings - ensure Users should get an average rating for their articles [Feature #161255359]
maxwellgithinji
changed the title
161255359 Ft rate article
161255359 Users should be able to rate an article
Nov 8, 2018
- ensure user rating works correctly [Feature #161255359]
Pull Request Test Coverage Report for Build 218
💛 - Coveralls |
maxwellgithinji
changed the title
161255359 Users should be able to rate an article
#161255359 Users should be able to rate an article
Nov 8, 2018
- Add new folder in apps articles/ [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
- Add models for articles - Add seriaizers for articles - Add views for articles - Add url routes for articles [Feature #161255358]
- User can create an article - User can fetch all articles - User can fetch a single article - User can update their article - User can delete their article - Add tests for all the CRUD functions [Feature #161255358]
- Add new folder in apps articles/ [Feature #161255358]
- Add models for articles - Add seriaizers for articles - Add views for articles - Add url routes for articles [Feature #161255358]
- User can create an article - User can fetch all articles - User can fetch a single article - User can update their article - User can delete their article - Add tests for all the CRUD functions [Feature #161255358]
- Rebase from develop and merge conflicts [Feature #161255358]
- ensure Only authenticated users should be able to provide ratings - ensure Users should get an average rating for their articles [Feature #161255359]
- ensure user rating works correctly [Feature #161255359]
maxwellgithinji
force-pushed
the
ft-rate-article-161255359
branch
2 times, most recently
from
November 9, 2018 05:46
ddcbb10
to
0fa67bc
Compare
- ensure the PR is up to date with develop and any other open PR's in order to prepare the brach for merging [Feature #161255359]
maxwellgithinji
force-pushed
the
ft-rate-article-161255359
branch
from
November 9, 2018 05:57
0fa67bc
to
6ef28f7
Compare
- ensure merge conflicts are fixed [Featur #161255359]
- ensure merge conflicts on serializers are fixed [Featur #161255359]
AnguleMathias
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
njeri-ngigi
approved these changes
Nov 9, 2018
- ensure redendant code is fixed [Feature #161255359]
3N61N33R
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Rating an article
ft-rate-article-161255359
branch/api/articles/<str: slug>/rate/
endpoint with JSON data ,e.g.{"rate": <int>}
using POSTViewing average rating of an article
/api/articles/<str: slug>/
endpoint using GETAny background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots
Rate an article
Get average rating
Questions