#161348759 Rating an article #16

judeinno · 2018-12-08T16:14:06Z

What does this PR do?

A user is able to see the rating of an article and also rate the article.

Description of Task to be completed?

Add radio buttons for the user to be able to rate an article.
Add 5-star rating to show the article rating.

How should this be manually tested?

Click any rating on the radio buttons and click submit.
The when a user gets an article by ID the rating is returned in 5-star rating format.

What are the relevant pivotal tracker stories?

#161348759

Screenshots

codeclimate · 2018-12-08T16:14:25Z

src/reducers/ratingReducer/ratingReducer.js

+const initalState = {
+};
+
+const ratingReducer = (state = initalState, action) => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-08T16:14:25Z

src/components/Rating/Rating.test.js

+  });
+});
+
+describe('<Rating />', () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-08T16:14:25Z

src/reducers/ratingReducer/ratingReducer.test.js

+    expect(ratingReducer(initalState, action)).toEqual(expectedData);
+  });
+
+  test('test rating post data succesfully', () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-08T16:14:25Z

src/reducers/ratingReducer/ratingReducer.test.js

+    expect(ratingReducer(initalState, action)).toEqual(expectedData);
+  });
+
+  test('test rating post succesfully', () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-08T16:14:25Z

src/actions/ratingActions/index.js

+  const headers = {
+    headers: { Authorization: token },
+  };
+  return axios.post(url, data, headers)


Identical blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-09T04:27:58Z

src/actions/ratingActions/index.js

+  payload: rate,
+});
+
+export const fetchRatingThunk = () => dispatch => axios.get('https://ah-backend-thanos-staging.herokuapp.com/api/articles/7')


Identical blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-09T06:11:24Z

src/actions/ratingActions/ratingActions.test.js

+      type: ACTION_TYPE.GET_RATING_SUCCESS,
+    }];
+    const store = mockStore({});
+    store.dispatch(fetchRatingThunk()).then(() => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2018-12-09T06:11:24Z

src/actions/ratingActions/ratingActions.test.js

+      payload: { message: 'ok' },
+    }];
+    const store = mockStore({});
+    store.dispatch(postRating()).then(() => {


Similar blocks of code found in 3 locations. Consider refactoring.

codeclimate · 2018-12-09T06:11:24Z

src/actions/ratingActions/ratingActions.test.js

+    // import and pass your custom axios instance to this method
+    moxios.uninstall();
+  });
+  test('Successful get rating action', () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-09T06:11:24Z

src/actions/ratingActions/ratingActions.test.js

+      payload: rate,
+    }));
+  });
+  test('successfull post rating action', () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-09T08:22:25Z

src/containers/LoginPage/LoginPage.test.js

-};
-
+const mockStore = configureMockStore([thunk]);
+const LoginComponent = shallow(<Login onChange={jest.fn()} onSubmit={jest.fn()} />);


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-09T08:22:25Z

src/components/Rating/Rating.test.js

+
+describe('<Rating />', () => {
+  test('renders the component', () => {
+    const RatingComponent = shallow(


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate

The PR diff size of 15976 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 15993 lines exceeds the maximum allowed for the inline comments feature.

brucemakallan

Thanks for fixing the tests and code climate issues. Looks good.

RachaelNantale

Looks Good, The UI is well implemented

codeclimate · 2018-12-18T09:11:15Z

src/actions/ratingActions/ratingActions.test.js

+      ));
+    });
+  });
+  test('get rate successfull', () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-18T09:11:15Z

src/actions/ratingActions/ratingActions.test.js

+      ));
+    });
+  });
+  test('get rate Failed', () => {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate

The PR diff size of 15078 lines exceeds the maximum allowed for the inline comments feature.

- Add 5 star rating for a single article - Add radio buttons for a user to rate an article. [#161348759]

codeclimate

The PR diff size of 15079 lines exceeds the maximum allowed for the inline comments feature.

codeclimate · 2018-12-18T11:46:47Z

Code Climate has analyzed commit 1796c96 and detected 0 issues on this pull request.

View more on Code Climate.

judeinno added the still in progress Still being worked on label Dec 8, 2018

codeclimate bot reviewed Dec 8, 2018

View reviewed changes

judeinno force-pushed the ft-rating-article-161348759 branch from 5356397 to bf1aee2 Compare December 9, 2018 04:27

codeclimate bot reviewed Dec 9, 2018

View reviewed changes

judeinno force-pushed the ft-rating-article-161348759 branch from bf1aee2 to 968f36c Compare December 9, 2018 06:11

codeclimate bot reviewed Dec 9, 2018

View reviewed changes

judeinno force-pushed the ft-rating-article-161348759 branch 8 times, most recently from c1a233f to d646cd1 Compare December 9, 2018 08:22

codeclimate bot reviewed Dec 9, 2018

View reviewed changes

judeinno force-pushed the ft-rating-article-161348759 branch 6 times, most recently from 70058d9 to 0cfd840 Compare December 10, 2018 08:29

judeinno requested review from Sulaiman-Mozes, dnuwa, RachaelNantale, brucemakallan and tibetegya December 10, 2018 08:40

judeinno force-pushed the ft-rating-article-161348759 branch from 0cfd840 to fdf2ba8 Compare December 10, 2018 09:11

judeinno added ready ready for merging and removed still in progress Still being worked on labels Dec 10, 2018

judeinno force-pushed the ft-rating-article-161348759 branch from fdf2ba8 to ace3248 Compare December 10, 2018 09:51

codeclimate bot reviewed Dec 13, 2018

View reviewed changes

judeinno force-pushed the ft-rating-article-161348759 branch from 6f5ecd5 to 079043a Compare December 13, 2018 10:38

codeclimate bot reviewed Dec 13, 2018

View reviewed changes

brucemakallan previously approved these changes Dec 17, 2018

View reviewed changes

RachaelNantale previously approved these changes Dec 17, 2018

View reviewed changes

dnuwa previously approved these changes Dec 17, 2018

View reviewed changes

Sulaiman-Mozes previously approved these changes Dec 17, 2018

View reviewed changes

judeinno dismissed stale reviews from Sulaiman-Mozes, dnuwa, RachaelNantale, and brucemakallan via dc2a9f8 December 18, 2018 08:40

judeinno force-pushed the ft-rating-article-161348759 branch 3 times, most recently from dda685a to 9345bd1 Compare December 18, 2018 09:10

codeclimate bot reviewed Dec 18, 2018

View reviewed changes

judeinno force-pushed the ft-rating-article-161348759 branch 6 times, most recently from bbab163 to 3383e6e Compare December 18, 2018 11:36

codeclimate bot reviewed Dec 18, 2018

View reviewed changes

ft(Rating): Rating an article

1796c96

- Add 5 star rating for a single article - Add radio buttons for a user to rate an article. [#161348759]

judeinno force-pushed the ft-rating-article-161348759 branch from 3383e6e to 1796c96 Compare December 18, 2018 11:46

codeclimate bot reviewed Dec 18, 2018

View reviewed changes

Sulaiman-Mozes approved these changes Dec 18, 2018

View reviewed changes

brucemakallan approved these changes Dec 18, 2018

View reviewed changes

dnuwa approved these changes Dec 18, 2018

View reviewed changes

tibetegya merged commit 337bbac into develop Dec 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#161348759 Rating an article #16

#161348759 Rating an article #16

judeinno commented Dec 8, 2018 •

edited

Loading

codeclimate bot Dec 8, 2018

codeclimate bot Dec 8, 2018

codeclimate bot Dec 8, 2018

codeclimate bot Dec 8, 2018

codeclimate bot Dec 8, 2018

codeclimate bot Dec 9, 2018

codeclimate bot Dec 9, 2018

codeclimate bot Dec 9, 2018

codeclimate bot Dec 9, 2018

codeclimate bot Dec 9, 2018

codeclimate bot Dec 9, 2018

codeclimate bot Dec 9, 2018

codeclimate bot left a comment

codeclimate bot left a comment

brucemakallan left a comment

RachaelNantale left a comment

codeclimate bot Dec 18, 2018

codeclimate bot Dec 18, 2018

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot commented Dec 18, 2018

#161348759 Rating an article #16

#161348759 Rating an article #16

Conversation

judeinno commented Dec 8, 2018 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

What are the relevant pivotal tracker stories?

Screenshots

codeclimate bot Dec 8, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 8, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 8, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 8, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 8, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 9, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 9, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 9, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 9, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 9, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 9, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 9, 2018

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

brucemakallan left a comment

Choose a reason for hiding this comment

RachaelNantale left a comment

Choose a reason for hiding this comment

codeclimate bot Dec 18, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 18, 2018

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot commented Dec 18, 2018

judeinno commented Dec 8, 2018 •

edited

Loading