#161254669 : favorite and unfavorite an article #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSteelGuy
requested review from
abadojack,
wrotich,
code-sleuth and
kipropbrian
houndci-bot
reviewed
Nov 14, 2018
TheSteelGuy
force-pushed
the
ft-favorite-article-161254669
branch
2 times, most recently
from
339a7e3
to
60e8b91
Compare
houndci-bot
reviewed
Nov 14, 2018
authors/apps/article/serializers.py
Outdated
|
|
||
| 'url', | ||
| 'favorited') | ||
|
|
TheSteelGuy
force-pushed
the
ft-favorite-article-161254669
branch
from
60e8b91
to
6aaaf03
Compare
houndci-bot
reviewed
Nov 14, 2018
authors/urls.py
Outdated
| @@ -42,3 +50,4 @@ | |||
| ('authors.apps.report.urls', | |||
| 'report'), | |||
| namespace='report'))] | |||
|
|
|||
Pull Request Test Coverage Report for Build 572
💛 - Coveralls |
TheSteelGuy
force-pushed
the
ft-favorite-article-161254669
branch
2 times, most recently
from
c9e12cf
to
44a8890
Compare
houndci-bot
reviewed
Nov 14, 2018
authors/apps/article/views.py
Outdated
| @@ -25,6 +30,12 @@ | |||
| RetrieveAPIView, | |||
| DestroyAPIView, | |||
| get_object_or_404, RetrieveUpdateDestroyAPIView) | |||
| from rest_framework.permissions import ( | |||
There was a problem hiding this comment.
redefinition of unused 'AllowAny' from line 2
redefinition of unused 'IsAuthenticated' from line 2
redefinition of unused 'IsAuthenticatedOrReadOnly' from line 2
authors/apps/article/views.py
Outdated
| CommentsSerializer) | ||
| CommentsSerializer, | ||
| FavoriteSerializer) | ||
| from rest_framework.views import APIView |
There was a problem hiding this comment.
redefinition of unused 'APIView' from line 4
authors/apps/article/serializers.py
Outdated
| @@ -185,3 +197,15 @@ def update(self, instance, validated_data): | |||
| instance.body = validated_data.get('body', instance.body) | |||
| instance.save() | |||
| return instance | |||
| class FavoriteSerializer(serializers.ModelSerializer): | |||
authors/apps/article/serializers.py
Outdated
| @@ -9,6 +9,9 @@ | |||
|
|
|||
| from authors.apps.profiles.models import UserProfile | |||
| from .models import RateArticle, Comments | |||
| from rest_framework.validators import UniqueTogetherValidator | |||
|
|
|||
| from .models import RateArticle, Favorite | |||
There was a problem hiding this comment.
redefinition of unused 'RateArticle' from line 11
authors/apps/article/renderers.py
Outdated
| @@ -24,3 +24,14 @@ def render(self, data, media_type=None, renderer_context=None): | |||
| class CommentsThreadsRenderer(AuthorsJSONRenderer): | |||
| charset = 'utf-8' | |||
| object_name = 'threads' | |||
| from rest_framework.renderers import JSONRenderer | |||
| from rest_framework import status | |||
There was a problem hiding this comment.
module level import not at top of file
authors/apps/article/renderers.py
Outdated
| @@ -24,3 +24,14 @@ def render(self, data, media_type=None, renderer_context=None): | |||
| class CommentsThreadsRenderer(AuthorsJSONRenderer): | |||
| charset = 'utf-8' | |||
| object_name = 'threads' | |||
| from rest_framework.renderers import JSONRenderer | |||
There was a problem hiding this comment.
expected 2 blank lines after class or function definition, found 0
module level import not at top of file
authors/apps/article/models.py
Outdated
| @@ -172,3 +172,14 @@ class Comments(TimestampedModel): | |||
|
|
|||
| def __str__(self): | |||
| return self.body | |||
|
|
|||
| class Favorite(models.Model): | |||
authors/apps/article/models.py
Outdated
| @@ -172,3 +172,14 @@ class Comments(TimestampedModel): | |||
|
|
|||
| def __str__(self): | |||
| return self.body | |||
|
|
|||
TheSteelGuy
force-pushed
the
ft-favorite-article-161254669
branch
from
44a8890
to
db6e646
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds functionality for users to favorite or unfavorite an articleDescription of Task to be completed?
How should this be manually tested?
$ virtualenv env
$ source env/bin/activate
$ cd env
$ git clone https://github.com/andela/ah-orcas.git
$ git checkout ft-favorite-article-161254669
$ source .env
$ python manage.py runserver
Any background context you want to provide?
Authentication is requiredWhat are the relevant pivotal tracker stories?
#161254669