Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#162451894 fix heroku #46

Merged
merged 1 commit into from
Dec 5, 2018
Merged

#162451894 fix heroku #46

merged 1 commit into from
Dec 5, 2018

Conversation

Eyansky
Copy link
Contributor

@Eyansky Eyansky commented Dec 5, 2018

What does this PR do?

  • Fix the issue with rejection requests.

Description of Task to be completed?

  • Allow all origins to be accepted.

How should this be manually tested?

  • Clone this repo
$ git clone https://github.com/andela/ah-orcas
  • Navigate to this branch
$ git clone bg-heroku-fix-162451894
  • Install the requirements and run the migrations.
  • Try accessing the endpoints from your react project.

Any background context you want to provide?

  • This sorts to fix the issue on frontend that rejects the requests. The issue was CORS was not well implemented.
  • I have tried this and it has worked locally.

What are the relevant pivotal tracker stories?

#162451894

Copy link
Contributor

@wrotich wrotich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check your commit message: I can't get the meaning of this sentence, probably add more color to it

  • resetting removed files
    cor?? kindly check the spelling, should be cors
    @Eyansky

@Eyansky
Copy link
Contributor Author

Eyansky commented Dec 5, 2018

@wrotich I have rectified that mistake. Kindly check it again.

- resetting removed line

[Deliver #162451894]
Copy link
Contributor

@TheSteelGuy TheSteelGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@code-sleuth code-sleuth merged commit 22f9a0a into develop Dec 5, 2018
@coveralls
Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 720

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.499%

Totals Coverage Status
Change from base Build 716: 0.0%
Covered Lines: 908
Relevant Lines: 1026

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants