-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#167190540 Implement Follow And Unfollow User Feature #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryade
added
pr:review
This is PR is currently under review by team
type:feature
A new feature
labels
Aug 6, 2019
henryade
requested review from
Adekoreday,
chialuka,
abdulfatai360,
ayodejiAA,
dinobi and
JuwonAbiola
August 6, 2019 19:42
henryade
force-pushed
the
ft-user-follower-167190540
branch
3 times, most recently
from
August 7, 2019 07:55
e19e848
to
da037f8
Compare
henryade
force-pushed
the
ft-user-follower-167190540
branch
from
August 7, 2019 10:04
da037f8
to
006c41c
Compare
dinobi
reviewed
Aug 7, 2019
dinobi
reviewed
Aug 7, 2019
dinobi
reviewed
Aug 7, 2019
henryade
force-pushed
the
ft-user-follower-167190540
branch
from
August 7, 2019 13:09
006c41c
to
bd8de31
Compare
Adekoreday
previously approved these changes
Aug 7, 2019
henryade
force-pushed
the
ft-user-follower-167190540
branch
from
August 8, 2019 06:16
bd8de31
to
047b438
Compare
Adekoreday
previously approved these changes
Aug 8, 2019
henryade
force-pushed
the
ft-user-follower-167190540
branch
from
August 8, 2019 11:41
047b438
to
ca534aa
Compare
henryade
added
pr:ready
This PR is ready to be merged
and removed
pr:review
This is PR is currently under review by team
labels
Aug 8, 2019
Adekoreday
previously approved these changes
Aug 8, 2019
henryade
dismissed stale reviews from Adekoreday, abdulfatai360, JuwonAbiola, and chialuka
via
August 8, 2019 13:39
b5c5148
henryade
force-pushed
the
ft-user-follower-167190540
branch
from
August 8, 2019 13:39
c259b93
to
b5c5148
Compare
henryade
requested review from
Adekoreday,
chialuka,
JuwonAbiola and
abdulfatai360
August 8, 2019 13:40
Adekoreday
previously approved these changes
Aug 8, 2019
JuwonAbiola
previously approved these changes
Aug 8, 2019
henryade
force-pushed
the
ft-user-follower-167190540
branch
from
August 8, 2019 15:16
b5c5148
to
2452e79
Compare
chialuka
previously approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
henryade
force-pushed
the
ft-user-follower-167190540
branch
from
August 8, 2019 15:38
2452e79
to
252f4ea
Compare
- create user follower model - create follow user route - create unfollow user route - create get followers route - create get followings route - write end to end test on all route - write model unit tests [Delivers #167190540]
henryade
force-pushed
the
ft-user-follower-167190540
branch
from
August 8, 2019 15:50
252f4ea
to
f587288
Compare
dinobi
approved these changes
Aug 8, 2019
abdulfatai360
approved these changes
Aug 8, 2019
Adekoreday
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows users to follow and unfollow other users, get all followers and get all users they follow.
Description of Task proposed in this pull request?
How should this be manually tested (Quality Assurance)?
To Follow
POST /api/v1/profiles/{username}/follow
add the first users token to the authorization headerTo get All followers
GET /api/v1/profiles/followers
add the first users token to the authorization headerTo get All followings
GET /api/v1/profiles/followings
add the first users token to the authorization headerTo Unfollow
DELETE /api/v1/profiles/{username}/follow
add the first users token to the authorization headerWhat are the relevant pivotal tracker stories?
Any background context you want to add (Operations Impact)?
N/A
What I have learned working on this feature:
Screenshots:
User Successfully follows another user:
User Successfully unfollow another user:
Other User View All Followers:
User View All Followings: