#162752831 Refactored notifications response #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickynyairo
changed the title
rickynyairo
requested review from
Adoniswalker,
asheux,
botnetdobbs and
gtsofa
Adoniswalker
approved these changes
Dec 19, 2018
asheux
approved these changes
Dec 20, 2018
gtsofa
approved these changes
Dec 20, 2018
botnetdobbs
approved these changes
Dec 20, 2018
rickynyairo
force-pushed
the
ch-refactor-notifications-response-162752831
branch
from
3e889ec
to
87e31e7
Compare
rickynyairo
force-pushed
the
ch-refactor-notifications-response-162752831
branch
from
87e31e7
to
2e6ec9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Changes the notifications response to include a resource url that points to where the user can locate the particular notification.
The
URL uses the frontend domain so that users will be directed to the frontend.
Any other information
The PR requires the following to be set in your backend environment variables
Remotely, it is set as:
Screenshots