#161966613 Comments #22
Conversation
verenceLola
requested review from
SilasKenneth,
Mnickii,
actlikewill,
SnyderMbishai,
TeamoreA and
salma-nyagaka
SilasKenneth
changed the base branch from
ft-create-article-161966610
to
develop
verenceLola
force-pushed
the
ft-comments-161966613
branch
from
0a91691
to
6e97f0e
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| """ | ||
| delete comment with comment_id of article with specified slug | ||
| """ | ||
| try: |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| update comment with comment_id or artcle_slug | ||
| """ | ||
| reply_data = request.data.get('reply', {}) | ||
| try: |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| """ | ||
| delete comment with comment_id of article with specified slug | ||
| """ | ||
| try: |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| update comment with comment_id or artcle_slug | ||
| """ | ||
| comment_data = request.data.get('comment', {}) | ||
| try: |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| **validated_data | ||
| ) | ||
|
|
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
- Add functionality to allow commenting articles - Add functionality to allow replying to an article comment(allow threading comments) [Delivers #161966613]
- write tests for commenting articles [Delivers #161966613]
…ality - write test for testing replying to comments of articles [Delivers #161966613]
verenceLola
force-pushed
the
ft-comments-161966613
branch
from
6e97f0e
to
43ddabd
Compare
| **validated_data | ||
| ) | ||
|
|
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| model = Reply | ||
| exclude = ('comment',) | ||
|
|
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| 'replies' | ||
| ) | ||
|
|
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| comments = self.queryset.filter(**filters) | ||
| serializer = CommentSerializer(comments, many=True) | ||
| data = serializer.data | ||
| return Response({ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| replies = self.queryset.filter(comment__id=comment_pk) | ||
| serializer = ReplySerializer(replies, many=True) | ||
| data = serializer.data | ||
| return Response({ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 43ddabd and detected 11 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
What does this pull request do?
This PR implements the CRUD methods for comments and comment replies.
Description of the tasks to be completed?
create article's comment
POST /api/articles/:slug/commentsget article's comments
GET /api/articles/:slug/commentsupdate article's comment
PUT /api/articles/:slug/comments/:iddelete article's comment
DELETE /api/articles/:slug/comments/:idtest the above functionalities
How should this be manually tested?
git clone https://github.com/andela/ah-technocrats.gitcd ah-technocratsgit checkout ft-comments-161966613python3 -m venv venvand thensource venv/bin/activatepip install -r requirements.txtpython manage.py makemigrationspython manage.py migratepython manage.py runservertesting automatically:
python manage.py testto run automatic teststesting manually:
Screenshots:
Commenting on an article
Get comments for an article
Update an article's comment
Delete article's comment
Reply to a comment:
Get comment's replies:
Edit a comment's reply:
Delete a comment's reply:
Testsing
What are the relevant Pivotal Tracker Stories
#161966613
Checklist: