#161966611: Users should rate articles #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
authors/apps/articles/views.py
Outdated
| except Exception as ex: | ||
| response = dict(errors={"message": "There was a problem sending the rating" | ||
| " try again later."}) | ||
| return Response(response, status=status.HTTP_503_SERVICE_UNAVAILABLE) |
There was a problem hiding this comment.
Avoid too many return statements within this function.
TeamoreA
requested review from
SnyderMbishai,
TeamoreA,
salma-nyagaka,
actlikewill,
verenceLola,
Mnickii and
evansmusomi
SilasKenneth
force-pushed
the
ft-user-rate-articles-161966611
branch
from
3125f14
to
4ea92d1
Compare
SilasKenneth
force-pushed
the
ft-user-rate-articles-161966611
branch
12 times, most recently
from
53c462f
to
6cca04f
Compare
- This delivers code to allow users rate articles in the api [Delivers #161966611]
SilasKenneth
force-pushed
the
ft-user-rate-articles-161966611
branch
from
6cca04f
to
7f5a82d
Compare
|
Code Climate has analyzed commit 7f5a82d and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The user should be able to rate articles and also see ratings for all the articles in the authorshaven API.
Description of Task to be completed?
The user should be able to rate articles on the authorshaven api. The users should then be able to see the ratings depicted on the articles page when they request for it. The user, in this case an API user authenticated or not should be able to view all ratings of articles.
To rate an article the user must be authenticated first.
How should this be manually tested?
To test the application follow the steps below.
git clone https://github.com/andela/ah-technocrats.gitcd ah-technocratsgit checkout ft-user-rate-articles-161966611to switch to current branchvirtualenv env -p python3to create a virtual environment for the applicationsource env/bin/activatepip install -r requirements.txtpython manage.py testto testAny background context you want to provide?
What are the relevant pivotal tracker stories?
#161966611
Checklist:
Screenshots
How ratings of articles appear when you view multiple articles
The screen you get when you rate an article
The ratings when viewing a single article have distributions
That is, if ten users rate the article 5 then the distribution will be
{'5': '1'}