#164427956 feature for notification for articles from followed users. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created migration for notifications - Created migration for user notifications - Created migration for user notification channels. [Finishes #164530687]
- Created migration for notifications - Created migration for user notifications - Created migration for user notification channels. [Finishes #164530687]
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
- Create feature for notification for users when author they follow publishes a new article - Fix bug with follow/unfollow feature - Write tests for the notification [Delivers #164427956]
…into ft-article-notification-on-follow-164427956
…into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
[Finishes #164427956]
houndci-bot
reviewed
Mar 13, 2019
server/database/migrations/20190311091450-create-user-notification.js
Outdated
Show resolved
Hide resolved
server/database/migrations/20190311091413-create-notification.js
Outdated
Show resolved
Hide resolved
…into ft-article-notification-on-follow-164427956
houndci-bot
reviewed
Mar 13, 2019
[Finishes #164427956]
houndci-bot
reviewed
Mar 13, 2019
| @@ -0,0 +1,74 @@ | |||
| import chaiHttp from 'chai-http'; | |||
There was a problem hiding this comment.
Definition for rule 'prettier/prettier' was not found prettier/prettier
[Finishes #164427956]
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
andela-gike
suggested changes
Mar 13, 2019
package.json
Outdated
| "eslint-plugin-import": "^2.16.0", | ||
| "eslint-plugin-prettier": "^3.0.1", |
There was a problem hiding this comment.
I thought we agreed to remove prettier, why do we still have it here
package.json
Outdated
| "husky": "^1.3.1", | ||
| "lint-staged": "^8.1.5", | ||
| "mocha-lcov-reporter": "^1.3.0", | ||
| "nyc": "^13.3.0" | ||
| "prettier": "^1.16.4" |
There was a problem hiding this comment.
Same with here, kindly confirm this
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
…/github.com/andela/artemis-ah-backend into ft-article-notification-on-follow-164427956
andela-gike
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create a feature for notification when a user another user follows publishes an article.
Description of Task to be completed?
How should this be manually tested?
npm installto install the dependencies.npm testto run the tests.What are the relevant pivotal tracker stories?
#164427956