#167164986 Users should be able to create novels #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerocodes
requested review from
Ukhu,
OvieMudi,
benisi,
allebd,
Rythae and
WilliamsOhworuka
Nerocodes
force-pushed
the
feature/167164986/create-novels-endpoint
branch
from
85da93d
to
5c3fbdc
Compare
Nerocodes
force-pushed
the
feature/167164986/create-novels-endpoint
branch
from
5c3fbdc
to
b8cc1ad
Compare
allebd
reviewed
Jul 31, 2019
Ukhu
reviewed
Aug 1, 2019
Ukhu
reviewed
Aug 1, 2019
Nerocodes
force-pushed
the
feature/167164986/create-novels-endpoint
branch
from
b8cc1ad
to
5bdeec6
Compare
Nerocodes
force-pushed
the
feature/167164986/create-novels-endpoint
branch
from
5bdeec6
to
5caef49
Compare
#167164979 add user login feature
Nerocodes
force-pushed
the
feature/167164986/create-novels-endpoint
branch
from
5caef49
to
37e8071
Compare
OvieMudi
reviewed
Aug 1, 2019
Nerocodes
force-pushed
the
feature/167164986/create-novels-endpoint
branch
from
37e8071
to
f2267c7
Compare
allebd
reviewed
Aug 2, 2019
Nerocodes
force-pushed
the
feature/167164986/create-novels-endpoint
branch
from
f2267c7
to
0ab8965
Compare
Nerocodes
force-pushed
the
feature/167164986/create-novels-endpoint
branch
from
0ab8965
to
e6f08ac
Compare
WilliamsOhworuka
force-pushed
the
staging
branch
from
80afc92
to
e550e81
Compare
added verifyToken middleware [Starts #167164986]
Nerocodes
force-pushed
the
feature/167164986/create-novels-endpoint
branch
from
e6f08ac
to
cab80b7
Compare
joel-ace
reviewed
Aug 5, 2019
| * @returns {object} json | ||
| */ | ||
| const createNovel = async (req, res) => { | ||
| const newNovel = req.body; |
There was a problem hiding this comment.
what happens if a column that's not in the database is sent in the request body?
There was a problem hiding this comment.
It's handled in the createNovel service. That's where I destructure the fields from the body
joel-ace
reviewed
Aug 5, 2019
| body | ||
| } = novel; | ||
| const getGenre = await Genre.findOne({ where: { name: genre } }); | ||
| const slug = `${title.toLowerCase().split(' ').join('-')}-${author.id}`; |
There was a problem hiding this comment.
why are we appending the author id to the slug? the slug should be unique
There was a problem hiding this comment.
It is unique, the reason for the author id is to allow for different users to create novels with the same name but to limit the user from uploading a novel twice or with the same name. I used medium article links as a reference https://medium.com/@nerocodes/a-new-tool-i-found-5c634618c2bf
joel-ace
reviewed
Aug 5, 2019
| .isEmpty() | ||
| .exists() | ||
| .withMessage(`${field} is a required field`) | ||
| .isIn(['action', 'thriller', 'romance', 'fiction', 'motivational']) |
There was a problem hiding this comment.
I don't think hardcoding this here is the best way to go considering you only covered a few genres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal tracker story
#167164986
What does this PR do?
Summary of Task
How can this be tested?
Screenshots (if appropriate)