#170947581 users are able to chat #53

Ntare22 · 2020-03-16T15:51:35Z

What does this PR do?

implements users are able to chat

Description of Task to be completed?

add chat.html page
add chat functionality to the ioMiddleware

How should this be manually tested?

clone this repo
run npm install
register a user through /api/v1/auth/register
access the chat through /public/chat.html
enter the token of the user in the localStorage by opening the developer tools on your browser and going to Application.
create a token key and add the token
start writing messages

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#170947581

Screenshots (if appropriate)

Questions:

src/index.js

Baraka-Mugisha · 2020-03-21T07:19:59Z

Could you add a screenshot to the PR showing this feature?

izzett222 · 2020-03-23T10:31:55Z

src/tests/chat.test.js

+    clientSocket2.disconnect();
+    clientSocket3.disconnect();
+    sinon.restore();
+    // done();


could you remove commented code

izzett222 · 2020-03-23T10:38:06Z

public/chat.html

+      socket.on('connection', (msg) => {
+        console.log(msg);
+      });


hey @Ntare22 are you using this piece pf code

bbaime98 · 2020-03-23T15:23:24Z

src/services/localesServices/locales/en.json

-}
+	"Request not found or not yours to approve": "Request not found or not yours to approve",
+	"Request not found or not yours to manage": "Request not found or not yours to manage"
+}


add new line please.

bbaime98 · 2020-03-23T19:38:03Z

Use the following to totally remove package-lock: git rm --cached package-lock.json then git add, commit and push. Remember to add it first into gitignore as well.

add chat.html page add chat functionality to the ioMiddleware [ #170947581 in progress]

This reverts commit 8752a4e.

add chat.html page add chat functionality to the ioMiddleware [ #170947581 in progress]

bbaime98

Great work Jim!

add chat.html page add chat functionality to the ioMiddleware add tests [ Finishes #170947581 ]

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch from 0f03596 to 97255f9 Compare March 16, 2020 15:54

Ntare22 added the work in progress label Mar 16, 2020

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch 3 times, most recently from 48d2c9e to da3e372 Compare March 17, 2020 17:57

Ntare22 added ready for review and removed work in progress labels Mar 17, 2020

Baraka-Mugisha suggested changes Mar 19, 2020

View reviewed changes

src/index.js Outdated Show resolved Hide resolved

izzett222 force-pushed the ft-users-able-to-chat-170947581 branch from da3e372 to 6fc3421 Compare March 19, 2020 10:05

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch 4 times, most recently from 912c4a4 to 6ef8a12 Compare March 20, 2020 16:22

Ntare22 temporarily deployed to devrepublic-ft-users-ab-s4nj7i March 20, 2020 16:39 Inactive

Ntare22 temporarily deployed to devrepublic-ft-users-ab-s4nj7i March 20, 2020 16:43 Inactive

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch from 6ef8a12 to 88ff378 Compare March 21, 2020 15:38

Ntare22 requested a review from Baraka-Mugisha March 23, 2020 07:00

Ntare22 temporarily deployed to devrepublic-ft-users-ab-ypjqax March 23, 2020 09:17 Inactive

izzett222 suggested changes Mar 23, 2020

View reviewed changes

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch from 88ff378 to c623e4a Compare March 23, 2020 10:41

Ntare22 deployed to devrepublic-ft-users-ab-kfbzhc March 23, 2020 10:55 View deployment

Ntare22 requested a review from izzett222 March 23, 2020 11:06

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch from c623e4a to 00a7234 Compare March 23, 2020 11:09

Ntare22 temporarily deployed to devrepublic-ft-users-ab-kfbzhc March 23, 2020 11:09 Inactive

izzett222 previously approved these changes Mar 23, 2020

View reviewed changes

Baraka-Mugisha previously approved these changes Mar 23, 2020

View reviewed changes

bbaime98 previously approved these changes Mar 23, 2020

View reviewed changes

Ntare22 deployed to devrepublic-ft-users-ab-vf9wot March 23, 2020 11:23 View deployment

Ntare22 removed the ready for review label Mar 23, 2020

bbaime98 suggested changes Mar 23, 2020

View reviewed changes

Ntare22 dismissed Baraka-Mugisha’s stale review via fbb9a49 March 23, 2020 15:26

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch 2 times, most recently from fbb9a49 to 659b79c Compare March 23, 2020 15:32

Ntare22 requested review from bbaime98, izzett222 and Baraka-Mugisha March 23, 2020 15:42

Ntare22 temporarily deployed to devrepublic-ft-users-ab-1rdi0o March 23, 2020 15:52 Inactive

izzett222 previously approved these changes Mar 23, 2020

View reviewed changes

Ntare22 dismissed izzett222’s stale review via 1c2fdab March 24, 2020 09:09

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch from 659b79c to 1c2fdab Compare March 24, 2020 09:09

Ntare22 temporarily deployed to devrepublic-ft-users-ab-oc2yek March 24, 2020 09:25 Inactive

Ntare22 added 3 commits March 24, 2020 11:28

ft(users are able to chat):

93fb0dd

add chat.html page add chat functionality to the ioMiddleware [ #170947581 in progress]

Revert "ft(users are able to chat):"

3999315

This reverts commit 8752a4e.

ft(users are able to chat):

41218d1

add chat.html page add chat functionality to the ioMiddleware [ #170947581 in progress]

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch from 1c2fdab to eb413f5 Compare March 24, 2020 09:31

Ntare22 temporarily deployed to devrepublic-ft-users-ab-6l2cc8 March 24, 2020 09:38 Inactive

bbaime98 previously approved these changes Mar 24, 2020

View reviewed changes

Ntare22 dismissed bbaime98’s stale review via 67394d1 March 24, 2020 09:53

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch from eb413f5 to 67394d1 Compare March 24, 2020 09:53

ft(users are able to chat):

4d4ecb3

add chat.html page add chat functionality to the ioMiddleware add tests [ Finishes #170947581 ]

Ntare22 force-pushed the ft-users-able-to-chat-170947581 branch from 67394d1 to 4d4ecb3 Compare March 24, 2020 10:01

Ntare22 temporarily deployed to devrepublic-ft-users-ab-m5rce2 March 24, 2020 10:13 Inactive

izzett222 approved these changes Mar 24, 2020

View reviewed changes

Baraka-Mugisha approved these changes Mar 24, 2020

View reviewed changes

bbaime98 approved these changes Mar 24, 2020

View reviewed changes

Ntare22 temporarily deployed to devrepublic-ft-users-ab-m5rce2 March 24, 2020 10:35 Inactive

jabichris merged commit 269cd21 into develop Mar 24, 2020

Ntare22 temporarily deployed to devrepublic-bn March 25, 2020 15:00 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#170947581 users are able to chat #53

#170947581 users are able to chat #53

Ntare22 commented Mar 16, 2020 •

edited

Loading

Baraka-Mugisha commented Mar 21, 2020

izzett222 Mar 23, 2020

izzett222 Mar 23, 2020

bbaime98 Mar 23, 2020

bbaime98 commented Mar 23, 2020 •

edited

Loading

bbaime98 left a comment

#170947581 users are able to chat #53

#170947581 users are able to chat #53

Conversation

Ntare22 commented Mar 16, 2020 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Questions:

Baraka-Mugisha commented Mar 21, 2020

izzett222 Mar 23, 2020

Choose a reason for hiding this comment

izzett222 Mar 23, 2020

Choose a reason for hiding this comment

bbaime98 Mar 23, 2020

Choose a reason for hiding this comment

bbaime98 commented Mar 23, 2020 • edited Loading

bbaime98 left a comment

Choose a reason for hiding this comment

Ntare22 commented Mar 16, 2020 •

edited

Loading

bbaime98 commented Mar 23, 2020 •

edited

Loading