-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#167131452: view modules #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chekwas88
requested review from
Tyak99,
fortunee,
Ochowo,
beejay1293 and
chizzydavid
July 18, 2019 08:59
chekwas88
force-pushed
the
ft-view-modules-167131452
branch
from
July 18, 2019 11:23
f9d5a76
to
b8d24c3
Compare
Tyak99
reviewed
Jul 18, 2019
Tyak99
reviewed
Jul 18, 2019
Tyak99
reviewed
Jul 18, 2019
Tyak99
reviewed
Jul 18, 2019
chekwas88
force-pushed
the
ft-view-modules-167131452
branch
from
July 18, 2019 13:11
b8d24c3
to
f3e12de
Compare
chekwas88
force-pushed
the
ft-view-modules-167131452
branch
from
July 18, 2019 13:49
f3e12de
to
c6a5340
Compare
fortunee
reviewed
Jul 18, 2019
chekwas88
force-pushed
the
ft-view-modules-167131452
branch
from
July 18, 2019 14:11
c6a5340
to
d131334
Compare
fortunee
suggested changes
Jul 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Chekwas, please review my comments and refactor accordingly. Thanks
chekwas88
force-pushed
the
ft-view-modules-167131452
branch
from
July 18, 2019 15:42
d131334
to
dc604d3
Compare
chekwas88
force-pushed
the
ft-view-modules-167131452
branch
from
July 18, 2019 16:23
dc604d3
to
f2e1dc9
Compare
create components style components add initial redux actions
chekwas88
force-pushed
the
ft-view-modules-167131452
branch
from
July 18, 2019 16:44
f2e1dc9
to
5fdf8eb
Compare
chekwas88
force-pushed
the
ft-view-modules-167131452
branch
from
July 18, 2019 16:49
5fdf8eb
to
d20c3f4
Compare
fortunee
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @chekwas88 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
Any background context you want to provide?
N/A
What are the relevant Github issues?
N/A
Questions:
N/A
Screenshot