Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167131452: view modules #24

Merged
merged 6 commits into from
Jul 18, 2019
Merged

#167131452: view modules #24

merged 6 commits into from
Jul 18, 2019

Conversation

chekwas88
Copy link
Contributor

What does this PR do?

  • Create the Dashboard Page

Description of Task to be completed?

  • create module component
  • create Dashboard component
  • create modules actions
  • create a reducer for modules actions
  • Write tests for the components and actions

Any background context you want to provide?

N/A

What are the relevant Github issues?

N/A

Questions:

N/A

Screenshot

image

@Tyak99 Tyak99 had a problem deploying to freyja-frontend-staging-pr-24 July 18, 2019 08:59 Failure
@Tyak99 Tyak99 had a problem deploying to freyja-frontend-staging-pr-24 July 18, 2019 11:23 Failure
@chekwas88 chekwas88 changed the title Ft view modules 167131452 #167131452: view modules Jul 18, 2019
.sass-lint.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
@Tyak99 Tyak99 had a problem deploying to freyja-frontend-staging-pr-24 July 18, 2019 13:11 Failure
@Tyak99 Tyak99 had a problem deploying to freyja-frontend-staging-pr-24 July 18, 2019 13:49 Failure
@Tyak99 Tyak99 had a problem deploying to freyja-frontend-staging-pr-24 July 18, 2019 14:11 Failure
@chekwas88 chekwas88 requested a review from Tyak99 July 18, 2019 14:19
Copy link
Contributor

@fortunee fortunee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Chekwas, please review my comments and refactor accordingly. Thanks

src/components/Button/button.scss Outdated Show resolved Hide resolved
src/components/Card/card.scss Outdated Show resolved Hide resolved
src/test/components/Modules.spec.js Outdated Show resolved Hide resolved
src/views/Dashboard/Dashboard.scss Outdated Show resolved Hide resolved
src/views/Signup/SignUp.scss Outdated Show resolved Hide resolved
src/views/Signup/SignUp.scss Outdated Show resolved Hide resolved
src/views/Signup/SignUp.scss Outdated Show resolved Hide resolved
store/actions/moduleActions.js Outdated Show resolved Hide resolved
@Tyak99 Tyak99 temporarily deployed to freyja-frontend-staging-pr-24 July 18, 2019 15:42 Inactive
@Tyak99 Tyak99 had a problem deploying to freyja-frontend-staging-pr-24 July 18, 2019 16:23 Failure
@Tyak99 Tyak99 temporarily deployed to freyja-frontend-staging-pr-24 July 18, 2019 16:44 Inactive
Copy link
Contributor

@fortunee fortunee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @chekwas88 👍

@fortunee fortunee merged commit a2fd917 into develop Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants