Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(login): user recieve jwt on login #12

Merged
merged 3 commits into from
Jul 5, 2018
Merged

feature(login): user recieve jwt on login #12

merged 3 commits into from
Jul 5, 2018

Conversation

rovilay
Copy link
Contributor

@rovilay rovilay commented Jul 3, 2018 •
edited
Loading

What does this PR do?

  • It adds user login API route that returns JWT on successful login
  • It adds tests for user login API route
  • It updates tests for user signup API route
  • It updates user response format
  • It adds profile image field to user schema

Description of Task to be completed?

  • When a new user tries to login, provided the necessary login credentials (email and password) are present, then he/she should receive a token.

How should this be manually tested?

  • npm run test

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#158487961

Screenshots (if appropriate)

N/A

Questions:

N/A

@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 12:59 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from ded3654 to bcf03c3 Compare July 3, 2018 13:13
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 13:14 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from bcf03c3 to 5164761 Compare July 3, 2018 13:21
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 13:21 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 5164761 to 1195d0e Compare July 3, 2018 13:49
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 13:50 Inactive
@rovilay
feature(login): user recieve jwt on login
15f42ec 
- Add user login api route
- Add user login api controller
- Add test for login api route
- Refactor signup api test

[Finishes #158487961]
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 14:19 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch 2 times, most recently from ee63209 to 87d8805 Compare July 3, 2018 14:23
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 14:23 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 87d8805 to f43a808 Compare July 3, 2018 14:45
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 14:45 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from f43a808 to 55c2fe1 Compare July 3, 2018 15:11
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 15:11 Inactive
@coveralls
Copy link

coveralls commented Jul 3, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 166

  • 83 of 83 (100.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.06%) to 48.896%
Files with Coverage Reduction New Missed Lines %
server/test/user/model.js 2 95.89%
Totals Coverage Status
Change from base Build 100: 2.06%
Covered Lines: 743
Relevant Lines: 1324
💛 - Coveralls

@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 55c2fe1 to db2e861 Compare July 3, 2018 15:22
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 15:22 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch 2 times, most recently from 6616ea2 to 5232bcb Compare July 3, 2018 15:31
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 15:31 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 5232bcb to 4eb91cb Compare July 3, 2018 15:55
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 15:56 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 4eb91cb to 9b416fb Compare July 3, 2018 16:09
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 16:09 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 9b416fb to e8f599f Compare July 3, 2018 16:12
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 16:12 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch 2 times, most recently from 60dae3f to 988365f Compare July 3, 2018 16:15
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 16:16 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 988365f to 17d8f7d Compare July 3, 2018 16:17
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 16:18 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 17d8f7d to f91f519 Compare July 3, 2018 22:33
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 22:33 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from f91f519 to 4db398e Compare July 3, 2018 22:36
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 22:36 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 4db398e to 2320528 Compare July 3, 2018 22:38
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 22:38 Inactive
@rovilay
Merge branch 'feature/158487961/user-jwt-on-login' of github.com:ande…
164fef9 
…la/gondor-cfh into feature/158487961/user-jwt-on-login
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 2320528 to 164fef9 Compare July 3, 2018 22:41
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 3, 2018 22:41 Inactive
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 4, 2018 13:24 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from c41ddf6 to 901581a Compare July 4, 2018 13:55
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 4, 2018 13:55 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 901581a to 20fa453 Compare July 5, 2018 08:25
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 5, 2018 08:25 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from 20fa453 to b6a1172 Compare July 5, 2018 08:27
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 5, 2018 08:27 Inactive
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from b6a1172 to edbde13 Compare July 5, 2018 08:29
@otseobande otseobande temporarily deployed to gondor-cfh-staging-pr-12 July 5, 2018 08:29 Inactive
@rovilay
feature(login): user recieve jwt on login
12584a5 
- Update user API controller response body format
- Update user API controller response Messages
- Add profileImage to user schema
- change user schema variable name to camelcase
- Update test in relation to updates
- rename .eslintrc.json to .eslintrc

[Updates #158487961]
@rovilay rovilay force-pushed the feature/158487961/user-jwt-on-login branch from edbde13 to 12584a5 Compare July 5, 2018 09:45
@VictoriaOffoma VictoriaOffoma merged commit c2a7c04 into staging Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rovilay @coveralls @otseobande @VictoriaOffoma