Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# 16247863 email confirmation link fix #59

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

wiztemple
Copy link
Contributor

What does this PR do?

  • reset email confirmation url to point to the frontend

Description of tasks to be completed?

  • add a url to redirect users to frontend

How can this be manually tested?

  • on the terminal run git clone https://github.com/andela/haven-ah-backend.git.
  • run git checkout email-confirmation-bug-fix-16247863
  • ensure that PostgreSQL is running on your local machine.
  • run npm install to install the npm packages..
  • To test on postman: run npm run start-dev and open up postman.

What are the relevant pivotal tracker stories?

Screenshots(if appropriate)

@wiztemple wiztemple force-pushed the email-confirmation-bug-fix-16247863 branch from c6764e5 to 06829da Compare December 6, 2018 17:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 961

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 98.165%

Totals Coverage Status
Change from base Build 959: 0.001%
Covered Lines: 1010
Relevant Lines: 1018

💛 - Coveralls

- add a url to redirect users to frontend
@wiztemple wiztemple force-pushed the email-confirmation-bug-fix-16247863 branch from 06829da to 89dfc0c Compare December 12, 2018 10:55
@wiztemple wiztemple added the Ready Ready for review label Dec 21, 2018
@seyi-adeleke seyi-adeleke merged commit 998cd73 into develop Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants