Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#158175324 Write blog posts on the health checks site #23

Merged
merged 2 commits into from
Jul 16, 2018

Conversation

solnsubuga
Copy link
Contributor

What does this PR do?

This PR allows a user to write blog posts on the health checks site.

Description of Task to be completed?

  • Move pagination buttons on a new line.

How should this be manually tested?

  • Checkout the branch and start the application ./manage.py runserver
  • Add some blog posts
  • Navigate to the blog
  • Buttons should be on a new line.

What are the relevant pivotal tracker stories?

#158175324

Screenshots (if appropriate)

screen shot 2018-07-16 at 13 14 11

@coveralls
Copy link

coveralls commented Jul 16, 2018

Pull Request Test Coverage Report for Build 308

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.615%

Totals Coverage Status
Change from base Build 296: 0.0%
Covered Lines: 1980
Relevant Lines: 2368

💛 - Coveralls

@john555
Copy link

john555 commented Jul 16, 2018

  • Get rid of "midnight" in the publishing date on /my-blogs/.
  • On the publishing date's date picker, make it such that it is impossible to select a past date.

@solnsubuga
Copy link
Contributor Author

@john555 Your suggestions have been addressed.

@john555
Copy link

john555 commented Jul 16, 2018

This is pending.
screen shot 2018-07-16 at 3 17 17 pm

Get rid of the "midnight" text in the publishing date.

@solnsubuga
Copy link
Contributor Author

@john555 I had not seen that. It's also resolved.

@john555 john555 merged commit 4b496e5 into develop Jul 16, 2018
@john555 john555 deleted the ft-blog-158175324 branch July 16, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants