Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#158175315 Extend the maximum timeout and grace periods #8

Merged
merged 1 commit into from
Jun 29, 2018
Merged

#158175315 Extend the maximum timeout and grace periods #8

merged 1 commit into from
Jun 29, 2018

Conversation

ja-odur
Copy link
Contributor

@ja-odur ja-odur commented Jun 27, 2018 •
edited
Loading

What does this PR do?

  • Extends the grace and time-out periods.

Description of Task to be completed?

  • To extend the maximum time accepted by the timeout form to one year.
  • Modify UI, so that a user can set these extended periods

How should this be manually tested?

  • Clone the project from GitHub git clone https://github.com/andela/hc-wits-kla.git and set it up as indicated in the README.md file.
  • After cloning, cd into the project directory and run the environment setup in the project README
  • Run python manage.py compress to recompress the static files.
  • Start the project python manage.py runserver.
  • Login and add a new check. You should be able to adjust the time-out and grace periods to upto a year as shown in the screenshot below.

What are the relevant pivotal tracker stories?

Screenshots

screenshot before the changes
screenshot before

screenshot after the changes
screenshot

@solnsubuga
Copy link
Contributor

For the screenshots, maybe you could add the screenshot before the changes and the one after the changes such that we can quickly glance at the new UI changes.

@ja-odur
Copy link
Contributor Author

ja-odur commented Jun 27, 2018

@solnsubuga I have added the screenshot before the changes for comparison as you suggested earlier.

wasswa-derick
wasswa-derick reviewed Jun 27, 2018
View reviewed changes
Copy link
Contributor

@wasswa-derick wasswa-derick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemingly the changes are okay for me.

Have reviewed the changes on the branch and all is well.

@Yiga-fred
Copy link
Contributor

The changes look good @ja-odur , good work the screen clearly show what you accomplished

Yiga-fred
Yiga-fred approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@Yiga-fred Yiga-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work changes look good

solnsubuga
solnsubuga approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@solnsubuga solnsubuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ja-odur ja-odur force-pushed the ft-extend-set-timeouts-158175315 branch from 1cb23d4 to 899f05d Compare June 28, 2018 11:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 85

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.984%
Totals Coverage Status
Change from base Build 69: 0.0%
Covered Lines: 1563
Relevant Lines: 1930
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 90

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.099%
Totals Coverage Status
Change from base Build 88: 0.0%
Covered Lines: 1579
Relevant Lines: 1947
💛 - Coveralls

@RrNn
Copy link
Collaborator

RrNn commented Jun 28, 2018 •
edited
Loading

@ja-odur this is great work. time selection is as smooth as before.

john555
john555 approved these changes Jun 29, 2018
View reviewed changes
Copy link

@john555 john555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Update your PR so that I may merge.

@ja-odur
[Feature #158175315] extend the maximum timeout and grace periods to …
f41812c 
…one year.

* smoothen scale to improve scale resolution
@ja-odur ja-odur force-pushed the ft-extend-set-timeouts-158175315 branch from 899f05d to f41812c Compare June 29, 2018 06:49
@john555 john555 merged commit 4b00cba into develop Jun 29, 2018
@john555 john555 deleted the ft-extend-set-timeouts-158175315 branch June 29, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasswa-derick wasswa-derick wasswa-derick left review comments

@john555 john555 john555 approved these changes

@solnsubuga solnsubuga solnsubuga approved these changes

@RrNn RrNn RrNn approved these changes

@Yiga-fred Yiga-fred Yiga-fred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ja-odur @solnsubuga @Yiga-fred @coveralls @RrNn @john555 @wasswa-derick